Recalc custom scrollbar style.

Recalc custom scrollbar style irrespective of root-layer-scrolls flag.
When chrome running on on root-layer-scrolls, page is scaled the style 
is recalculated and thickness is changed. Change in thickness sets 
informs owning renderer to set for childneedsLayout. This layout shall
happen after style reclac is completed, if this sequence is not executed,
then post layout we see the needsForLayout = true, which asserts and
crashes the chrome.

TESTED=fast/scrollbars/custom-scrollbar-thickness-change-on-zoom-crash.html
now passes with root layer scrolling

BUG=522389
(https://code.google.com/p/chromium/issues/detail?id=522389#c1)

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201356

[MuVen, 2015-08-24 11:12:40]

sataya.m@samsung.com changed reviewers:
+ skobes@chromium.org

[MuVen, 2015-08-24 11:12:40]

Skobes, PTAL.

Not sure if test cases are needed or not. As once we enable
virtual/scrollbars/ these tests will be covered.

[skobes, 2015-08-24 21:51:57]

On 2015/08/24 11:12:40, MuVen wrote:
> Skobes, PTAL.
> 
> Not sure if test cases are needed or not. As once we enable
> virtual/scrollbars/ these tests will be covered.

If possible, I'd like to avoid having FrameView involved at all in recalculating
the scrollbar styles for DeprecatedPaintLayerScrollableArea.  Can we use the
plumbing that already exists for custom scrollbars in
DeprecatedPaintLayerScrollableArea?

[MuVen, 2015-08-25 14:06:03]

On 2015/08/24 21:51:57, skobes wrote:
> On 2015/08/24 11:12:40, MuVen wrote:
> > Skobes, PTAL.
> > 
> > Not sure if test cases are needed or not. As once we enable
> > virtual/scrollbars/ these tests will be covered.
> 
> If possible, I'd like to avoid having FrameView involved at all in
recalculating
> the scrollbar styles for DeprecatedPaintLayerScrollableArea.  Can we use the
> plumbing that already exists for custom scrollbars in
> DeprecatedPaintLayerScrollableArea?

Hi Skobes, 

I see this above patch shall work for both frameview and
DPLSA even, fixing custom-scrollbar-thickness-change-on-zoom-crash.html.
As i debugged further for the other issue 
custom-scrollbar-inactive-for-iframe-expected.html This needs to debugged
further to find the root cause, As we are neglecting passing the owningFrame
while creating custom scrollbars for iframe in layoutObjectForScrollbar API.

so will pick-up one by one. PTAL.

Thanks,

[skobes, 2015-08-25 19:06:17]

On 2015/08/25 14:06:03, MuVen wrote:
> I see this above patch shall work for both frameview and
> DPLSA even, fixing custom-scrollbar-thickness-change-on-zoom-crash.html.
> As i debugged further for the other issue 
> custom-scrollbar-inactive-for-iframe-expected.html This needs to debugged
> further to find the root cause, As we are neglecting passing the owningFrame
> while creating custom scrollbars for iframe in layoutObjectForScrollbar API.
> 
> so will pick-up one by one. PTAL.

From your trybot results it looks like this regresses a few layout tests:
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...

[MuVen, 2015-08-26 14:20:07]

PTAL, let me know your inputs on this change.

[skobes, 2015-08-26 18:56:08]

Can you add a TESTED= line to the change description that says which test this
fixes?

e.g.

TESTED=fast/scrollbars/[name of test].html now passes with root layer scrolling

https://codereview.chromium.org/1310603003/diff/40001/Source/core/layout/Layo...
File Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/1310603003/diff/40001/Source/core/layout/Layo...
Source/core/layout/LayoutBox.cpp:239: bool rootLayerScrolls =
document().settings() && document().settings()->rootLayerScrolls();
I think you don't need to check the root layer scrolls setting.  If it's not
enabled, the LayoutView's ScrollableArea will not have scrollbars anyway.

[MuVen, 2015-08-27 05:28:19]

Patchset #4 (id:60001) has been deleted

[MuVen, 2015-08-27 11:56:05]

sataya.m@samsung.com changed reviewers:
+ szager@chromium.org
- skobes@chromium.org

[MuVen, 2015-08-27 11:56:05]

Hi Szager, 

PTAL. I have modifed as per skobes review comments.

Thanks,
~MuVen.

[szager1, 2015-08-27 17:26:31]

lgtm

[MuVen, 2015-08-27 19:35:03]

The CQ bit was checked by sataya.m@samsung.com

[commit-bot: I haz the power, 2015-08-27 19:35:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1310603003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1310603003/80001

[commit-bot: I haz the power, 2015-08-27 19:44:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-27 19:44:03]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[MuVen, 2015-08-27 19:48:15]

sataya.m@samsung.com changed reviewers:
+ pdr@chromium.org

[MuVen, 2015-08-27 19:48:16]

Thanks szager!!! 

@Pdr PTAL, Needs onwer stamp :) As skobes is OOO.

Thanks,
MuVen

[pdr., 2015-08-27 20:18:21]

On 2015/08/27 at 19:48:16, sataya.m wrote:
> Thanks szager!!! 
> 
> @Pdr PTAL, Needs onwer stamp :) As skobes is OOO.
> 
> Thanks,
> MuVen

Can we add an automated test for this?

[pdr., 2015-08-27 20:23:58]

On 2015/08/27 at 20:18:21, pdr wrote:
> On 2015/08/27 at 19:48:16, sataya.m wrote:
> > Thanks szager!!! 
> > 
> > @Pdr PTAL, Needs onwer stamp :) As skobes is OOO.
> > 
> > Thanks,
> > MuVen
> 
> Can we add an automated test for this?

It looks like tests in virtual/rootlayerscrolls/fast run with root layer
scrolling enabled. Can we move
LayoutTests/scrollbars/custom-scrollbar-thickness-change-on-zoom-crash.html to
LayoutTests/fast/scrollbars/custom-scrollbar-thickness-change-on-zoom-crash.html
to prove this works?

[MuVen, 2015-08-28 01:39:38]

On 2015/08/27 20:23:58, pdr wrote:
> On 2015/08/27 at 20:18:21, pdr wrote:
> > On 2015/08/27 at 19:48:16, sataya.m wrote:
> > > Thanks szager!!! 
> > > 
> > > @Pdr PTAL, Needs onwer stamp :) As skobes is OOO.
> > > 
> > > Thanks,
> > > MuVen
> > 
> > Can we add an automated test for this?
> 
> It looks like tests in virtual/rootlayerscrolls/fast run with root layer
> scrolling enabled. Can we move
> LayoutTests/scrollbars/custom-scrollbar-thickness-change-on-zoom-crash.html to
>
LayoutTests/fast/scrollbars/custom-scrollbar-thickness-change-on-zoom-crash.html
> to prove this works?

I'm working on to enable virtual/rootlayerscrolls/scrollbars/ folder.To avoid
duplication skobes mentioned not to add test case but to mention what testcase
this patch solves in the discription.

[pdr., 2015-08-28 01:40:24]

On 2015/08/28 at 01:39:38, sataya.m wrote:
> On 2015/08/27 20:23:58, pdr wrote:
> > On 2015/08/27 at 20:18:21, pdr wrote:
> > > On 2015/08/27 at 19:48:16, sataya.m wrote:
> > > > Thanks szager!!! 
> > > > 
> > > > @Pdr PTAL, Needs onwer stamp :) As skobes is OOO.
> > > > 
> > > > Thanks,
> > > > MuVen
> > > 
> > > Can we add an automated test for this?
> > 
> > It looks like tests in virtual/rootlayerscrolls/fast run with root layer
> > scrolling enabled. Can we move
> > LayoutTests/scrollbars/custom-scrollbar-thickness-change-on-zoom-crash.html
to
> >
LayoutTests/fast/scrollbars/custom-scrollbar-thickness-change-on-zoom-crash.html
> > to prove this works?
> 
> I'm working on to enable virtual/rootlayerscrolls/scrollbars/ folder.To avoid
duplication skobes mentioned not to add test case but to mention what testcase
this patch solves in the discription.

LGTM

[pdr., 2015-08-28 01:40:29]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-08-28 01:40:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1310603003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1310603003/80001

[commit-bot: I haz the power, 2015-08-28 01:45:23]

Committed patchset #4 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201356

[MuVen, 2015-08-28 01:48:23]

On 2015/08/28 01:45:23, commit-bot: I haz the power wrote:
> Committed patchset #4 (id:80001) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=201356

thanks pdr!!!