Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 1310583002: Change |use_alternative_service| not to disable Alternate Protocols. (Closed)

Created:
5 years, 4 months ago by Bence
Modified:
5 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change |use_alternative_service| not to disable Alternate Protocols. Currently, HttpNetworkSession::Params::use_alternative_service controls both Alternate Protocols and Alternative Services. However, Alternate Protocols is fully rolled out, therefore there is not need to disable it. This CL changes |use_alternative_service| to * disable parsing Alt-Svc headers (but not Alternate-Protocol ones); * disable following saved alternative service entries that point to different hosts (but not ones that point to the same host). The latter is necessary because a browser session might have this flag enabled and might save alternative services to disk, which we do not really want to follow in the next browser session if the flag is disabled. (Ones discovered through Alt-Svc pointing to the same host will still be respected.) BUG=524141 Committed: https://crrev.com/54ec34b7c174848672fc3ea08aba7289630df4a3 Cr-Commit-Position: refs/heads/master@{#345640}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Add tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -5 lines) Patch
M net/http/http_network_transaction.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 2 3 chunks +107 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 4 months ago (2015-08-21 14:23:00 UTC) #2
Ryan Hamilton
This change looks great. Needs tests, though.
5 years, 4 months ago (2015-08-24 18:18:29 UTC) #3
Bence
PTAL. On 2015/08/24 18:18:29, Ryan Hamilton wrote: > This change looks great. Needs tests, though. ...
5 years, 3 months ago (2015-08-26 17:19:28 UTC) #4
Ryan Hamilton
Thanks! LGTM
5 years, 3 months ago (2015-08-26 18:38:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310583002/40001
5 years, 3 months ago (2015-08-26 18:40:03 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-08-26 19:35:04 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 19:35:58 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/54ec34b7c174848672fc3ea08aba7289630df4a3
Cr-Commit-Position: refs/heads/master@{#345640}

Powered by Google App Engine
This is Rietveld 408576698