Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1310573007: Speculative fix for recording texture-backed SkImages into SkPictures. (Closed)

Created:
5 years, 3 months ago by bsalomon
Modified:
5 years, 3 months ago
CC:
blink-reviews, dshwang, Rik, Justin Novosad
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Speculative fix for recording texture-backed SkImages into SkPictures. SkImages that are backed by textures are being recorded into SkPictures that are rendered in multiple threads. This causes multiple threads to access the same Gr- and GL context, neither of which are thread safe. This change was suggested by junov@chromium.org as a possible fix. BUG=524717 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
bsalomon
5 years, 3 months ago (2015-08-28 13:42:04 UTC) #2
Stephen White
LGTM
5 years, 3 months ago (2015-08-28 13:43:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310573007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310573007/1
5 years, 3 months ago (2015-08-28 13:44:26 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 16:48:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201410

Powered by Google App Engine
This is Rietveld 408576698