chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc - Issue 1310553005: [Sync] Replace ProfileSyncComponentsFactory with SyncClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc

Issue 1310553005: [Sync] Replace ProfileSyncComponentsFactory with SyncClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Really fix GN Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_components_factory_impl.cc ('k') | chrome/browser/sync/profile_sync_components_factory_mock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc b/chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc

index d7173ea7d1aa2198c3e476d3b3084f821f14a6fa..62781573c970bf4d86b8dab155d5349115d85535 100644

--- a/chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc

+++ b/chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc

@@ -108,7 +108,7 @@ class ProfileSyncComponentsFactoryImplTest : public testing::Test {

ProfileOAuth2TokenService* token_service =

ProfileOAuth2TokenServiceFactory::GetForProfile(profile_.get());

scoped_ptr<ProfileSyncService> pss(new ProfileSyncService(

- scoped_ptr<ProfileSyncComponentsFactory>(

+ scoped_ptr<sync_driver::SyncApiComponentFactory>(

new ProfileSyncComponentsFactoryImpl(

profile_.get(),

command_line_.get(),

@@ -119,7 +119,8 @@ class ProfileSyncComponentsFactoryImplTest : public testing::Test {

make_scoped_ptr<SupervisedUserSigninManagerWrapper>(NULL),

token_service,

browser_sync::MANUAL_START));

- pss->factory()->RegisterDataTypes(pss.get());

+ pss->factory()->Initialize(pss.get());

+ pss->factory()->RegisterDataTypes();

DataTypeController::StateMap controller_states;

pss->GetDataTypeControllerStates(&controller_states);

EXPECT_EQ(DefaultDatatypesCount() - types.Size(), controller_states.size());

@@ -136,7 +137,7 @@ TEST_F(ProfileSyncComponentsFactoryImplTest, CreatePSSDefault) {