Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: components/sync_driver/profile_sync_components_factory.h

Issue 1310553005: [Sync] Replace ProfileSyncComponentsFactory with SyncClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Really fix GN Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_driver/profile_sync_components_factory.h
diff --git a/components/sync_driver/profile_sync_components_factory.h b/components/sync_driver/profile_sync_components_factory.h
deleted file mode 100644
index 718dd36f0f0f7e8daa36253aea52549e4d57d76b..0000000000000000000000000000000000000000
--- a/components/sync_driver/profile_sync_components_factory.h
+++ /dev/null
@@ -1,117 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef COMPONENTS_SYNC_DRIVER_PROFILE_SYNC_COMPONENTS_FACTORY_H__
-#define COMPONENTS_SYNC_DRIVER_PROFILE_SYNC_COMPONENTS_FACTORY_H__
-
-#include <string>
-
-#include "base/files/file_path.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/memory/weak_ptr.h"
-#include "components/sync_driver/data_type_controller.h"
-#include "components/sync_driver/sync_api_component_factory.h"
-#include "sync/internal_api/public/util/weak_handle.h"
-
-class PasswordStore;
-class Profile;
-class ProfileSyncService;
-
-namespace browser_sync {
-class SyncBackendHost;
-} // namespace browser_sync
-
-namespace invalidation {
-class InvalidationService;
-} // namespace invalidation
-
-namespace sync_driver {
-class AssociatorInterface;
-class ChangeProcessor;
-class DataTypeEncryptionHandler;
-class DataTypeErrorHandler;
-class DataTypeManager;
-class DataTypeManagerObserver;
-class DataTypeStatusTable;
-class GenericChangeProcessor;
-class LocalDeviceInfoProvider;
-class SyncPrefs;
-} // namespace sync_driver
-
-namespace syncer {
-class DataTypeDebugInfoListener;
-class SyncableService;
-} // namespace syncer
-
-namespace history {
-class HistoryBackend;
-} // namespace history
-
-// Factory class for all profile sync related classes.
-// TODO(zea): crbug.com/512768 Delete this interface and move all methods into
-// SyncApiComponentFactory.
-class ProfileSyncComponentsFactory
- : public sync_driver::SyncApiComponentFactory {
- public:
- // The various factory methods for the data type model associators
- // and change processors all return this struct. This is needed
- // because the change processors typically require a type-specific
- // model associator at construction time.
- //
- // Note: This interface is deprecated in favor of the SyncableService API.
- // New datatypes that do not live on the UI thread should directly return a
- // weak pointer to a syncer::SyncableService. All others continue to return
- // SyncComponents. It is safe to assume that the factory methods below are
- // called on the same thread in which the datatype resides.
- //
- // TODO(zea): Have all datatypes using the new API switch to returning
- // SyncableService weak pointers instead of SyncComponents (crbug.com/100114).
- struct SyncComponents {
- sync_driver::AssociatorInterface* model_associator;
- sync_driver::ChangeProcessor* change_processor;
- SyncComponents(sync_driver::AssociatorInterface* ma,
- sync_driver::ChangeProcessor* cp)
- : model_associator(ma), change_processor(cp) {}
- };
-
- ~ProfileSyncComponentsFactory() override {}
-
- // Creates and registers enabled datatypes with the provided
- // ProfileSyncService.
- virtual void RegisterDataTypes(ProfileSyncService* pss) = 0;
-
- // Instantiates a new DataTypeManager with a SyncBackendHost, a list of data
- // type controllers and a DataTypeManagerObserver. The return pointer is
- // owned by the caller.
- virtual sync_driver::DataTypeManager* CreateDataTypeManager(
- const syncer::WeakHandle<syncer::DataTypeDebugInfoListener>&
- debug_info_listener,
- const sync_driver::DataTypeController::TypeMap* controllers,
- const sync_driver::DataTypeEncryptionHandler* encryption_handler,
- browser_sync::SyncBackendHost* backend,
- sync_driver::DataTypeManagerObserver* observer) = 0;
-
- // Creating this in the factory helps us mock it out in testing.
- virtual browser_sync::SyncBackendHost* CreateSyncBackendHost(
- const std::string& name,
- Profile* profile,
- invalidation::InvalidationService* invalidator,
- const base::WeakPtr<sync_driver::SyncPrefs>& sync_prefs,
- const base::FilePath& sync_folder) = 0;
-
- // Creating this in the factory helps us mock it out in testing.
- virtual scoped_ptr<sync_driver::LocalDeviceInfoProvider>
- CreateLocalDeviceInfoProvider() = 0;
-
- // Legacy datatypes that need to be converted to the SyncableService API.
- virtual SyncComponents CreateBookmarkSyncComponents(
- ProfileSyncService* profile_sync_service,
- sync_driver::DataTypeErrorHandler* error_handler) = 0;
- virtual SyncComponents CreateTypedUrlSyncComponents(
- ProfileSyncService* profile_sync_service,
- history::HistoryBackend* history_backend,
- sync_driver::DataTypeErrorHandler* error_handler) = 0;
-};
-
-#endif // COMPONENTS_SYNC_DRIVER_PROFILE_SYNC_COMPONENTS_FACTORY_H__
« no previous file with comments | « components/sync_driver/non_ui_data_type_controller_unittest.cc ('k') | components/sync_driver/shared_change_processor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698