Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1310533005: [sqlite] Annotate Chromium-specific exposed functions with SQLITE_API. (Closed)

Created:
5 years, 4 months ago by Scott Hess - ex-Googler
Modified:
5 years, 4 months ago
Reviewers:
michaeln
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sqlite] Annotate Chromium-specific exposed functions with SQLITE_API. SQLITE_API is used to annotate functions exposed across a shlib boundary. Annonate our exposed functions. Also pull the functions added for WebDatabase support so that the blink implementation can depend on them directly rather than having a local extern "C" block. BUG=489444 Committed: https://crrev.com/80d8dda3a4953ffc9f6d87d8a94e74e037d90d5f Cr-Commit-Position: refs/heads/master@{#344934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -280 lines) Patch
M third_party/sqlite/amalgamation/sqlite3.h View 2 chunks +43 lines, -2 lines 0 comments Download
M third_party/sqlite/amalgamation/sqlite3.c View 8 chunks +50 lines, -2 lines 0 comments Download
M third_party/sqlite/patches/0005-Modify-default-VFS-to-support-WebDatabase.patch View 11 chunks +67 lines, -13 lines 0 comments Download
M third_party/sqlite/patches/0006-Virtual-table-supporting-recovery-of-corrupted-datab.patch View 8 chunks +23 lines, -17 lines 0 comments Download
A + third_party/sqlite/patches/0010-fts3-Fix-uninit-variable-in-fts3EvalDeferredPhrase.patch View 2 chunks +3 lines, -3 lines 0 comments Download
A + third_party/sqlite/patches/0011-backport-Fix-collation-dequoting.patch View 2 chunks +3 lines, -3 lines 0 comments Download
D third_party/sqlite/patches/0017-fts3-Fix-uninit-variable-in-fts3EvalDeferredPhrase.patch View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/sqlite/patches/0018-backport-Fix-collation-dequoting.patch View 1 chunk +0 lines, -205 lines 0 comments Download
M third_party/sqlite/src/src/os_unix.c View 4 chunks +5 lines, -0 lines 0 comments Download
M third_party/sqlite/src/src/os_win.c View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/sqlite/src/src/recover.c View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/sqlite/src/src/sqlite.h.in View 2 chunks +43 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Scott Hess - ex-Googler
The overall set of changes I'm aiming for: https://codereview.chromium.org/1312463002/ (browser) https://codereview.chromium.org/1308023003/ (blink) The basic problem ...
5 years, 4 months ago (2015-08-21 21:49:04 UTC) #2
michaeln
r/s lgtm
5 years, 4 months ago (2015-08-21 22:40:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310533005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310533005/1
5 years, 4 months ago (2015-08-21 22:54:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/59348)
5 years, 4 months ago (2015-08-21 23:09:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310533005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310533005/1
5 years, 4 months ago (2015-08-21 23:18:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/86495) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 4 months ago (2015-08-21 23:23:39 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310533005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310533005/1
5 years, 4 months ago (2015-08-21 23:34:54 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-22 00:19:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310533005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310533005/1
5 years, 4 months ago (2015-08-22 00:22:09 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-22 00:27:49 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 00:28:43 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80d8dda3a4953ffc9f6d87d8a94e74e037d90d5f
Cr-Commit-Position: refs/heads/master@{#344934}

Powered by Google App Engine
This is Rietveld 408576698