Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1310513013: fixes #314, super method tear offs (Closed)

Created:
5 years, 3 months ago by Jennifer Messerly
Modified:
5 years, 3 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add test #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -5 lines) Patch
M lib/runtime/_classes.js View 1 2 1 chunk +9 lines, -2 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 chunk +3 lines, -1 line 0 comments Download
M test/browser/language_tests.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
M test/codegen/expect/html_input.html View 1 chunk +2 lines, -2 lines 0 comments Download
A test/codegen/language/method_binding_test.dart View 1 chunk +149 lines, -0 lines 0 comments Download
A test/codegen/language/super_bound_closure_test.dart View 1 chunk +148 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Jennifer Messerly
btw, I figured out what's going on with the .html file churn. Working on a ...
5 years, 3 months ago (2015-09-09 22:56:01 UTC) #2
Jennifer Messerly
On 2015/09/09 22:56:01, John Messerly wrote: > btw, I figured out what's going on with ...
5 years, 3 months ago (2015-09-09 22:56:39 UTC) #3
Jennifer Messerly
On 2015/09/09 22:56:39, John Messerly wrote: > On 2015/09/09 22:56:01, John Messerly wrote: > > ...
5 years, 3 months ago (2015-09-09 22:56:53 UTC) #4
Jennifer Messerly
Fixed. Please take a look :)
5 years, 3 months ago (2015-09-09 22:59:44 UTC) #5
Jennifer Messerly
On 2015/09/09 22:59:44, John Messerly wrote: > Fixed. Please take a look :) FYI, ordering ...
5 years, 3 months ago (2015-09-09 23:13:19 UTC) #6
Leaf
lgtm with comment. https://codereview.chromium.org/1310513013/diff/20001/lib/runtime/_classes.js File lib/runtime/_classes.js (right): https://codereview.chromium.org/1310513013/diff/20001/lib/runtime/_classes.js#newcode196 lib/runtime/_classes.js:196: function bind(obj, name, f) { Update ...
5 years, 3 months ago (2015-09-10 17:42:41 UTC) #7
Jennifer Messerly
https://codereview.chromium.org/1310513013/diff/20001/lib/runtime/_classes.js File lib/runtime/_classes.js (right): https://codereview.chromium.org/1310513013/diff/20001/lib/runtime/_classes.js#newcode196 lib/runtime/_classes.js:196: function bind(obj, name, f) { On 2015/09/10 17:42:41, Leaf ...
5 years, 3 months ago (2015-09-10 19:23:08 UTC) #8
Jennifer Messerly
5 years, 3 months ago (2015-09-11 00:18:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:30001) manually as
3b7a6bf44c5613fc33a8fd4ddd246c00b7cf52d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698