content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java - Issue 1310513010: Support DomCode on Android devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

Issue 1310513010: Support DomCode on Android devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_evdev

Patch Set: Remove Android keycode->domcode conversion path Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/input/web_input_event_builders_android.cc ('K') | « content/browser/renderer_host/native_web_keyboard_event_android.cc ('k') | content/public/browser/native_web_keyboard_event.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

index e015031477694f3402351c1cdfe4b2c8761ad91a..109c8b8021d70a2f401804e823d5cc5c92c5242e 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

@@ -514,7 +514,7 @@ public class ImeAdapter {

mViewEmbedder.onImeEvent();

return nativeSendKeyEvent(mNativeImeAdapterAndroid, event, event.getAction(),

getModifiers(event.getMetaState()), event.getEventTime(), event.getKeyCode(),

- /*isSystemKey=*/false, event.getUnicodeChar());

+ event.getScanCode(), /*isSystemKey=*/false, event.getUnicodeChar());

}

boolean sendSyntheticKeyEvent(int eventType, long timestampMs, int keyCode, int modifiers,

@@ -611,8 +611,8 @@ public class ImeAdapter {

int eventType, long timestampMs, int keyCode, int modifiers, int unicodeChar);

private native boolean nativeSendKeyEvent(long nativeImeAdapterAndroid, KeyEvent event,

- int action, int modifiers, long timestampMs, int keyCode, boolean isSystemKey,

- int unicodeChar);

+ int action, int modifiers, long timestampMs, int keyCode, int scanCode,

+ boolean isSystemKey, int unicodeChar);

private static native void nativeAppendUnderlineSpan(long underlinePtr, int start, int end);