Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1310513008: Detach cache in DF routines rather than passing it in. (Closed)

Created:
5 years, 3 months ago by jvanverth1
Modified:
5 years, 3 months ago
Reviewers:
joshualitt, herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Detach cache in DF routines rather than passing it in. This removes nesting of cache accesses, which avoids a possible deadlock condition when the caches are the same. Committed: https://skia.googlesource.com/skia/+/157e6483fb089bf4d2e5cd2c18b521e5ab4ff32a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -30 lines) Patch
M src/gpu/GrAtlasTextContext.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 14 chunks +19 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jvanverth1
5 years, 3 months ago (2015-09-09 14:54:55 UTC) #2
joshualitt
On 2015/09/09 14:54:55, jvanverth1 wrote: lgtm
5 years, 3 months ago (2015-09-09 14:59:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310513008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310513008/1
5 years, 3 months ago (2015-09-09 15:00:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/157e6483fb089bf4d2e5cd2c18b521e5ab4ff32a
5 years, 3 months ago (2015-09-09 15:05:17 UTC) #6
herb_g
5 years, 3 months ago (2015-09-09 15:41:01 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698