Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: components/favicon/core/BUILD.gn

Issue 1310513006: Adding components to dependencies on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/core/BUILD.gn
diff --git a/components/favicon/core/BUILD.gn b/components/favicon/core/BUILD.gn
index 485d813f685a153d571e81cb50c7a07375bf024a..0dc633cb264a24267a99b6c7b90a8305b8f06a39 100644
--- a/components/favicon/core/BUILD.gn
+++ b/components/favicon/core/BUILD.gn
@@ -4,9 +4,6 @@
source_set("core") {
sources = [
- "fallback_icon_client.h",
- "fallback_icon_service.cc",
- "fallback_icon_service.h",
"favicon_client.h",
"favicon_driver.cc",
"favicon_driver.h",
@@ -36,6 +33,13 @@ source_set("core") {
"//ui/gfx",
"//url",
]
+ if (!is_ios) {
blundell 2017/03/22 10:29:09 FYI, these files should just be moved to //compone
+ sources += [
+ "fallback_icon_client.h",
+ "fallback_icon_service.cc",
+ "fallback_icon_service.h",
+ ]
+ }
}
source_set("unit_tests") {
« components/BUILD.gn ('K') | « components/favicon.gypi ('k') | components/metrics/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698