Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 13105005: [android] Adding a check not to send the same update to IME. (Closed)

Created:
7 years, 9 months ago by aurimas (slooooooooow)
Modified:
7 years, 9 months ago
Reviewers:
Yusuf, nilesh
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[android] Adding a check not to send the same update to IME. Adding a check for the previously sent value to avoid sending updates that are duplicates. This could happen when we have batch events. BUG=172845 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191142

Patch Set 1 #

Total comments: 2

Patch Set 2 : yusufo's nit #

Patch Set 3 : Removed DEBUG=true #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java View 1 2 3 4 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
aurimas (slooooooooow)
Hey Yusuf, Please take a look at this CL. Aurimas
7 years, 9 months ago (2013-03-27 00:28:22 UTC) #1
Yusuf
lgtm with nit On 2013/03/27 00:28:22, aurimas wrote: > Hey Yusuf, > > Please take ...
7 years, 9 months ago (2013-03-27 18:10:47 UTC) #2
Yusuf
https://codereview.chromium.org/13105005/diff/1/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java File content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java (right): https://codereview.chromium.org/13105005/diff/1/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java#newcode559 content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java:559: mLastUpdateCompositionEnd == compositionEnd) You need curly braces for this.
7 years, 9 months ago (2013-03-27 18:10:53 UTC) #3
aurimas (slooooooooow)
https://codereview.chromium.org/13105005/diff/1/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java File content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java (right): https://codereview.chromium.org/13105005/diff/1/content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java#newcode559 content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java:559: mLastUpdateCompositionEnd == compositionEnd) On 2013/03/27 18:10:53, Yusuf wrote: > ...
7 years, 9 months ago (2013-03-27 18:49:59 UTC) #4
aurimas (slooooooooow)
Hey Nilesh, Could you take a look at this CL? Thanks! Aurimas
7 years, 9 months ago (2013-03-27 20:58:52 UTC) #5
nilesh
LGTM
7 years, 9 months ago (2013-03-27 22:36:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/13105005/4003
7 years, 9 months ago (2013-03-28 02:29:17 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-28 13:01:25 UTC) #8
Message was sent while issue was closed.
Change committed as 191142

Powered by Google App Engine
This is Rietveld 408576698