Screenshot effect non-obvious

chrome/browser/ui/ash/screenshot_taker_unittest.cc

Index: chrome/browser/ui/ash/screenshot_taker_unittest.cc
diff --git a/chrome/browser/ui/ash/screenshot_taker_unittest.cc b/chrome/browser/ui/ash/screenshot_taker_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c3033810b9d8176005011dd3699018c94ec58fb4
--- /dev/null
+++ b/chrome/browser/ui/ash/screenshot_taker_unittest.cc
@@ -0,0 +1,121 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/shell.h"
+#include "ash/test/ash_test_base.h"
+#include "base/bind.h"
+#include "base/command_line.h"
+#include "base/file_util.h"
+#include "base/files/scoped_temp_dir.h"
+#include "base/message_loop.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/notifications/notification_ui_manager.h"
+#include "chrome/browser/ui/ash/screenshot_taker.h"

[sky, 2013/04/04 15:38:31]

This should be your first include (just like you have it in
screenshot_taker.cc).

[sschmitz, 2013/04/04 16:49:47]

Done.

+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/scoped_testing_local_state.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "chrome/test/base/testing_profile.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/test/test_browser_thread.h"
+#include "content/public/test/test_utils.h"
+#include "ui/aura/root_window.h"
+#include "ui/message_center/message_center_switches.h"
+
+namespace ash {
+namespace test {
+
+class ScreenshotTakerTest : public AshTestBase,
+                            public ScreenshotTakerObserver {
+ public:
+  ScreenshotTakerTest()
+      : local_state_(TestingBrowserProcess::GetGlobal()),
+        running_(false),
+        screenshot_complete_(false),
+        screenshot_result_(ScreenshotTakerObserver::SCREENSHOT_SUCCESS) {
+    CommandLine::ForCurrentProcess()->AppendSwitch(

[sky, 2013/04/04 15:38:31]

I'm pretty sure we reset switches like this between tests, but please verify
that.

[sschmitz, 2013/04/04 16:49:47]

Yup, the command line gets reset between tests. But I don't need to set the
switch... Removed it. Done.

+        message_center::switches::kEnableRichNotifications);
+    ui_thread_.reset(

[sky, 2013/04/04 15:38:31]

Most tests declare ui_thread_ like this by value, but this certainly works too.

[sschmitz, 2013/04/04 16:49:47]

Done.

+        new content::TestBrowserThread(content::BrowserThread::UI,
+                                       message_loop()));
+  }
+
+  // Overridden from ScreenshotTakerObserver
+  virtual void OnScreenshotCompleted(
+      ScreenshotTakerObserver::Result screenshot_result,
+      const base::FilePath& screenshot_path) OVERRIDE {
+    screenshot_complete_ = true;
+    screenshot_result_ = screenshot_result;
+    screenshot_path_ = screenshot_path;
+    if (!running_)
+      return;
+    message_loop_runner_->Quit();
+    running_ = false;
+  }
+
+ protected:
+  // ScreenshotTakerTest is a friend of ScreenshotTaker and therefore
+  // allowed to set the directory and basename.
+  void SetScreenshotDirectoryForTest(
+      ScreenshotTaker* screenshot_taker,
+      const base::FilePath& screenshot_directory) {
+    screenshot_taker->SetScreenshotDirectoryForTest(screenshot_directory);
+  }
+  void SetScreenshotBasenameForTest(
+      ScreenshotTaker* screenshot_taker,
+      const std::string& screenshot_basename) {
+    screenshot_taker->SetScreenshotBasenameForTest(screenshot_basename);
+  }
+
+  void Wait() {
+    if (screenshot_complete_)
+      return;
+    running_ = true;
+    message_loop_runner_ = new content::MessageLoopRunner;
+    message_loop_runner_->Run();
+    EXPECT_TRUE(screenshot_complete_);
+  }
+
+  ScopedTestingLocalState local_state_;
+  scoped_ptr<content::TestBrowserThread> ui_thread_;
+  bool running_;
+  bool screenshot_complete_;
+  ScreenshotTakerObserver::Result screenshot_result_;
+  base::FilePath screenshot_path_;
+  scoped_refptr<content::MessageLoopRunner> message_loop_runner_;
+
+  DISALLOW_COPY_AND_ASSIGN(ScreenshotTakerTest);
+};
+
+TEST_F(ScreenshotTakerTest, TakeScreenshot) {
+  TestingProfile profile;
+  ScreenshotTaker screenshot_taker(&profile);
+  screenshot_taker.AddObserver(this);
+  base::ScopedTempDir directory;
+  ASSERT_TRUE(directory.CreateUniqueTempDir());
+  SetScreenshotDirectoryForTest(&screenshot_taker, directory.path());
+  SetScreenshotBasenameForTest(&screenshot_taker, "Screenshot");
+
+  EXPECT_TRUE(screenshot_taker.CanTakeScreenshot());
+
+  screenshot_taker.HandleTakePartialScreenshot(
+      ash::Shell::GetPrimaryRootWindow(), gfx::Rect(0,0,100,100));

[sky, 2013/04/04 15:38:31]

0,0,100,100 -> 0, 0, 100, 100

[sschmitz, 2013/04/04 16:49:47]

Done.

+
+  EXPECT_FALSE(screenshot_taker.CanTakeScreenshot());
+
+  Wait();
+
+#if defined(OS_CHROMEOS)
+  // Screenshot notifications on Windows not yet turned on.
+  EXPECT_TRUE(g_browser_process->notification_ui_manager()->DoesIdExist(
+                  std::string("screenshot_001")));
+#endif
+
+  EXPECT_EQ(ScreenshotTakerObserver::SCREENSHOT_SUCCESS, screenshot_result_);
+
+  if (ScreenshotTakerObserver::SCREENSHOT_SUCCESS == screenshot_result_)
+    EXPECT_TRUE(file_util::PathExists(screenshot_path_));
+}
+
+}  // namespace test
+}  // namespace ash