Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1310493004: PPC: [runtime] Add %ToString and %_ToString and remove the TO_STRING builtin. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [runtime] Add %ToString and %_ToString and remove the TO_STRING builtin. Port 09de997b3504368d40644afa7310b90faff5d09c Original commit message: This adds a new ToString runtime function and a fast-path ToStringStub (which is just a simple dispatcher for existing functionality), and also implements %_ToName using the ToStringStub. R=bmeurer@chromium.org, jyan@ca.ibm.com, dstence@us.ibm.com, joransiu@ca.ibm.com BUG=v8:4307 LOG=n Committed: https://crrev.com/50916155b52cddd83c1f26834e0e57fe6f02ccd4 Cr-Commit-Position: refs/heads/master@{#30449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -25 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +34 lines, -9 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +2 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 3 months ago (2015-08-28 14:12:49 UTC) #1
dstence
lgtm
5 years, 3 months ago (2015-08-28 14:31:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310493004/1
5 years, 3 months ago (2015-08-28 15:07:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 15:34:13 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 15:34:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50916155b52cddd83c1f26834e0e57fe6f02ccd4
Cr-Commit-Position: refs/heads/master@{#30449}

Powered by Google App Engine
This is Rietveld 408576698