components/bubble/bubble_ui.h - Issue 1310483003: Add ability for a BubbleReference to update the BubbleUI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bubble/bubble_ui.h

Issue 1310483003: Add ability for a BubbleReference to update the BubbleUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bm-reference-own-file.gitbr

Patch Set: Add UI thread checks to controller Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/bubble/bubble_ui.h

diff --git a/components/bubble/bubble_ui.h b/components/bubble/bubble_ui.h

index 96f9f92bad8b4cfd880df8dd6608f2492767ac05..a64066056cf6afe1ef1584a553e2ebdd10085e98 100644

--- a/components/bubble/bubble_ui.h

+++ b/components/bubble/bubble_ui.h

@@ -7,9 +7,9 @@

#include "components/bubble/bubble_reference.h"

-class BubbleUI {

+class BubbleUi {

public:

- virtual ~BubbleUI() {}

+ virtual ~BubbleUi() {}

// Should display the bubble UI. BubbleReference is passed in so that the

// bubble UI can notify the BubbleManager if it needs to close.

« no previous file with comments | « components/bubble/bubble_manager_unittest.cc ('k') | no next file » | no next file with comments »