[Line Layout API] Add shim for Paint objects to access underlying LayoutObject

[Line Layout API] Add shim for Paint objects to access underlying LayoutObject

This CL allows us to remove another shim, InlineBox::deprecatedBoxModelObject,
and clears the way for removing all direct LayoutObject access in core/line/.

BUG=499321
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201274

[pilgrim_google, 2015-08-26 17:36:23]

pilgrim@chromium.org changed reviewers:
+ jsbell@chromium.org, leviw@chromium.org, ojan@chromium.org

[leviw_travelin_and_unemployed, 2015-08-26 17:54:03]

leviw@chromium.org changed reviewers:
+ esprehn@chromium.org

[leviw_travelin_and_unemployed, 2015-08-26 17:54:04]

This seems like a completely reasonable approach to me. You may also want to run
it by esprehn/ojan.

LGTM.

https://codereview.chromium.org/1310473003/diff/1/Source/core/core.gypi
File Source/core/core.gypi (right):

https://codereview.chromium.org/1310473003/diff/1/Source/core/core.gypi#newco...
Source/core/core.gypi:1931: 'paint/LineLayoutPaintShim.h',
I was thinking, we may end up needing this in another directory if we want to
enforce blocking it from being imported into Line Layout code.

https://codereview.chromium.org/1310473003/diff/1/Source/core/layout/line/Inl...
File Source/core/layout/line/InlineBox.h (left):

https://codereview.chromium.org/1310473003/diff/1/Source/core/layout/line/Inl...
Source/core/layout/line/InlineBox.h:274: // TODO(pilgrim) remove this
w00t!

https://codereview.chromium.org/1310473003/diff/1/Source/core/paint/InlineFlo...
File Source/core/paint/InlineFlowBoxPainter.cpp (right):

https://codereview.chromium.org/1310473003/diff/1/Source/core/paint/InlineFlo...
Source/core/paint/InlineFlowBoxPainter.cpp:325: LayoutBoxModelObject* boxModel =
toLayoutBoxModelObject(LineLayoutPaintShim::layoutObjectFrom(m_inlineFlowBox.boxModelObject()));
Man this is an unfortunately large amount of typing.

https://codereview.chromium.org/1310473003/diff/1/Source/core/paint/LineLayou...
File Source/core/paint/LineLayoutPaintShim.h (right):

https://codereview.chromium.org/1310473003/diff/1/Source/core/paint/LineLayou...
Source/core/paint/LineLayoutPaintShim.h:8: #include "core/layout/LayoutObject.h"
You should just be able to forward declare class LayoutObject;

https://codereview.chromium.org/1310473003/diff/1/Source/core/paint/LineLayou...
Source/core/paint/LineLayoutPaintShim.h:13: // TODO(pilgrim): remove this kludge
once Paint objects have a real API and no longer need access to the underlying
LayoutObject
Nit: capitalize remove and add a period.

[ojan, 2015-08-26 21:27:49]

lgtm

[ojan, 2015-08-26 21:28:54]

I agree. This turned out to be pretty reasonable in the end. A good stop-gap
until we get the rest of the API in place.

[pdr., 2015-08-26 21:32:17]

pdr@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2015-08-26 21:32:18]

https://codereview.chromium.org/1310473003/diff/20001/Source/core/paint/LineL...
File Source/core/paint/LineLayoutPaintShim.h (right):

https://codereview.chromium.org/1310473003/diff/20001/Source/core/paint/LineL...
Source/core/paint/LineLayoutPaintShim.h:14: // TODO(pilgrim): Remove this kludge
once Paint objects have a real API and no longer need access to the underlying
LayoutObject.
I don't want to derail this patch but this line is curious to me.

Where can I find out more about the paint api that doesn't access LayoutObjects?

[leviw_travelin_and_unemployed, 2015-08-26 21:41:42]

On 2015/08/26 at 21:32:18, pdr wrote:
>
https://codereview.chromium.org/1310473003/diff/20001/Source/core/paint/LineL...
> File Source/core/paint/LineLayoutPaintShim.h (right):
> 
>
https://codereview.chromium.org/1310473003/diff/20001/Source/core/paint/LineL...
> Source/core/paint/LineLayoutPaintShim.h:14: // TODO(pilgrim): Remove this
kludge once Paint objects have a real API and no longer need access to the
underlying LayoutObject.
> I don't want to derail this patch but this line is curious to me.
> 
> Where can I find out more about the paint api that doesn't access
LayoutObjects?

A wild PDR appears!

https://docs.google.com/document/d/1qc5Ni-TfCyvTi6DWBQQ_S_MWJlViJ-ikMEr1FSL0h...

[leviw_travelin_and_unemployed, 2015-08-26 21:42:45]

On 2015/08/26 at 21:41:42, leviw OOO thru 9-9 )( wrote:
> On 2015/08/26 at 21:32:18, pdr wrote:
> >
https://codereview.chromium.org/1310473003/diff/20001/Source/core/paint/LineL...
> > File Source/core/paint/LineLayoutPaintShim.h (right):
> > 
> >
https://codereview.chromium.org/1310473003/diff/20001/Source/core/paint/LineL...
> > Source/core/paint/LineLayoutPaintShim.h:14: // TODO(pilgrim): Remove this
kludge once Paint objects have a real API and no longer need access to the
underlying LayoutObject.
> > I don't want to derail this patch but this line is curious to me.
> > 
> > Where can I find out more about the paint api that doesn't access
LayoutObjects?
> 
> A wild PDR appears!
> 
>
https://docs.google.com/document/d/1qc5Ni-TfCyvTi6DWBQQ_S_MWJlViJ-ikMEr1FSL0h...

TL;DR: We want to codify our LayoutObject api. Paint will be assimilated. All
hail hypno-api.

[pilgrim_google, 2015-08-26 23:13:36]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2015-08-26 23:13:37]

The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org
Link to the patchset: https://codereview.chromium.org/1310473003/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2015-08-26 23:13:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1310473003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1310473003/20001

[commit-bot: I haz the power, 2015-08-27 00:17:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-27 00:17:20]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pilgrim_google, 2015-08-27 00:26:46]

wat

[pilgrim_google, 2015-08-27 00:27:02]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2015-08-27 00:27:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1310473003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1310473003/20001

[commit-bot: I haz the power, 2015-08-27 01:22:34]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201274