Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: runtime/vm/object_graph_test.cc

Issue 1310463005: - Ensure that HandleScope is initialized with a thread. (Remove (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_graph.cc ('k') | runtime/vm/object_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_graph_test.cc
diff --git a/runtime/vm/object_graph_test.cc b/runtime/vm/object_graph_test.cc
index 00f77685bbc6256b1cebd6cafc6270432cc4b515..3e0259af1f04687c4bfe4d395fb02f0208ca24f4 100644
--- a/runtime/vm/object_graph_test.cc
+++ b/runtime/vm/object_graph_test.cc
@@ -39,7 +39,7 @@ class CounterVisitor : public ObjectGraph::Visitor {
TEST_CASE(ObjectGraph) {
- Isolate* isolate = Isolate::Current();
+ Isolate* isolate = thread->isolate();
// Create a simple object graph with objects a, b, c, d:
// a+->b+->c
// +   +
@@ -99,7 +99,7 @@ TEST_CASE(ObjectGraph) {
ObjectGraph graph(isolate);
// A retaining path should end like this: c <- b <- a <- ...
{
- HANDLESCOPE(isolate);
+ HANDLESCOPE(thread);
// Test null, empty, and length 1 array.
intptr_t null_length = graph.RetainingPath(&c, Object::null_array());
intptr_t empty_length = graph.RetainingPath(&c, Object::empty_array());
@@ -110,7 +110,7 @@ TEST_CASE(ObjectGraph) {
EXPECT_LE(3, null_length);
}
{
- HANDLESCOPE(isolate);
+ HANDLESCOPE(thread);
Array& path = Array::Handle(Array::New(6, Heap::kNew));
// Trigger a full GC to increase probability of concurrent tasks.
isolate->heap()->CollectAllGarbage();
« no previous file with comments | « runtime/vm/object_graph.cc ('k') | runtime/vm/object_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698