Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/dart_api_impl.h

Issue 1310463005: - Ensure that HandleScope is initialized with a thread. (Remove (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.h
diff --git a/runtime/vm/dart_api_impl.h b/runtime/vm/dart_api_impl.h
index 46f85aa8929723b3b287042d478cd243ecc04512..742f80c4424c4dc5818a9a7e0a8f8e2274a01422 100644
--- a/runtime/vm/dart_api_impl.h
+++ b/runtime/vm/dart_api_impl.h
@@ -68,10 +68,11 @@ const char* CanonicalFunction(const char* func);
} \
} while (0)
-#define DARTSCOPE(isolate) \
- Isolate* __temp_isolate__ = (isolate); \
- CHECK_ISOLATE_SCOPE(__temp_isolate__); \
- HANDLESCOPE(__temp_isolate__);
+#define DARTSCOPE(thread) \
+ Thread* T = (thread); \
+ Isolate* I = T->isolate(); \
+ CHECK_ISOLATE_SCOPE(I); \
+ HANDLESCOPE(T);
#define RETURN_TYPE_ERROR(isolate, dart_handle, type) \
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698