Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: runtime/vm/service_test.cc

Issue 1310463005: - Ensure that HandleScope is initialized with a thread. (Remove (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/service_isolate.cc ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 6
7 #include "include/dart_tools_api.h" 7 #include "include/dart_tools_api.h"
8 #include "vm/dart_api_impl.h" 8 #include "vm/dart_api_impl.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/debugger.h" 10 #include "vm/debugger.h"
(...skipping 17 matching lines...) Expand all
28 ~ServiceTestMessageHandler() { 28 ~ServiceTestMessageHandler() {
29 free(_msg); 29 free(_msg);
30 } 30 }
31 31
32 bool HandleMessage(Message* message) { 32 bool HandleMessage(Message* message) {
33 if (_msg != NULL) { 33 if (_msg != NULL) {
34 free(_msg); 34 free(_msg);
35 } 35 }
36 36
37 // Parse the message. 37 // Parse the message.
38 MessageSnapshotReader reader(message->data(), 38 Thread* thread = Thread::Current();
39 message->len(), 39 MessageSnapshotReader reader(message->data(), message->len(), thread);
40 Isolate::Current(),
41 Thread::Current()->zone());
42 const Object& response_obj = Object::Handle(reader.ReadObject()); 40 const Object& response_obj = Object::Handle(reader.ReadObject());
43 String& response = String::Handle(); 41 String& response = String::Handle();
44 response ^= response_obj.raw(); 42 response ^= response_obj.raw();
45 _msg = strdup(response.ToCString()); 43 _msg = strdup(response.ToCString());
46 return true; 44 return true;
47 } 45 }
48 46
49 const char* msg() const { return _msg; } 47 const char* msg() const { return _msg; }
50 48
51 private: 49 private:
(...skipping 576 matching lines...) Expand 10 before | Expand all | Expand 10 after
628 Eval(lib, "[0, port, '0', '_getCpuProfile', ['tags'], ['Bogus']]"); 626 Eval(lib, "[0, port, '0', '_getCpuProfile', ['tags'], ['Bogus']]");
629 Service::HandleIsolateMessage(isolate, service_msg); 627 Service::HandleIsolateMessage(isolate, service_msg);
630 handler.HandleNextMessage(); 628 handler.HandleNextMessage();
631 // Expect error. 629 // Expect error.
632 EXPECT_SUBSTRING("\"error\"", handler.msg()); 630 EXPECT_SUBSTRING("\"error\"", handler.msg());
633 } 631 }
634 632
635 #endif // !defined(TARGET_ARCH_ARM64) 633 #endif // !defined(TARGET_ARCH_ARM64)
636 634
637 } // namespace dart 635 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/service_isolate.cc ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698