Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: Source/core/editing/VisibleUnits.cpp

Issue 1310433004: [Editing] Modify mostForward/BackwardCaretPosition naming confusion. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/VisibleUnits.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisibleUnits.cpp
diff --git a/Source/core/editing/VisibleUnits.cpp b/Source/core/editing/VisibleUnits.cpp
index 13d9ae5c497294c5cbd774f84df8bf78f73c9519..fe7075cefb30b5709fa99c4d7d151b142e1f7203 100644
--- a/Source/core/editing/VisibleUnits.cpp
+++ b/Source/core/editing/VisibleUnits.cpp
@@ -1697,7 +1697,7 @@ static bool isStreamer(const PositionIteratorAlgorithm<Strategy>& pos)
}
template <typename Strategy>
-static PositionAlgorithm<Strategy> mostForwardCaretPosition(const PositionAlgorithm<Strategy>& position, EditingBoundaryCrossingRule rule)
+static PositionAlgorithm<Strategy> mostBackwardCaretPosition(const PositionAlgorithm<Strategy>& position, EditingBoundaryCrossingRule rule)
{
TRACE_EVENT0("blink", "Position::upstream");
@@ -1813,18 +1813,18 @@ static PositionAlgorithm<Strategy> mostForwardCaretPosition(const PositionAlgori
return lastVisible.deprecatedComputePosition();
}
-Position mostForwardCaretPosition(const Position& position, EditingBoundaryCrossingRule rule)
+Position mostBackwardCaretPosition(const Position& position, EditingBoundaryCrossingRule rule)
{
- return mostForwardCaretPosition<EditingStrategy>(position, rule);
+ return mostBackwardCaretPosition<EditingStrategy>(position, rule);
}
-PositionInComposedTree mostForwardCaretPosition(const PositionInComposedTree& position, EditingBoundaryCrossingRule rule)
+PositionInComposedTree mostBackwardCaretPosition(const PositionInComposedTree& position, EditingBoundaryCrossingRule rule)
{
- return mostForwardCaretPosition<EditingInComposedTreeStrategy>(position, rule);
+ return mostBackwardCaretPosition<EditingInComposedTreeStrategy>(position, rule);
}
template <typename Strategy>
-PositionAlgorithm<Strategy> mostBackwardCaretPosition(const PositionAlgorithm<Strategy>& position, EditingBoundaryCrossingRule rule)
+PositionAlgorithm<Strategy> mostForwardCaretPosition(const PositionAlgorithm<Strategy>& position, EditingBoundaryCrossingRule rule)
{
TRACE_EVENT0("blink", "Position::downstream");
@@ -1942,14 +1942,14 @@ PositionAlgorithm<Strategy> mostBackwardCaretPosition(const PositionAlgorithm<St
return lastVisible.deprecatedComputePosition();
}
-Position mostBackwardCaretPosition(const Position& position, EditingBoundaryCrossingRule rule)
+Position mostForwardCaretPosition(const Position& position, EditingBoundaryCrossingRule rule)
{
- return mostBackwardCaretPosition<EditingStrategy>(position, rule);
+ return mostForwardCaretPosition<EditingStrategy>(position, rule);
}
-PositionInComposedTree mostBackwardCaretPosition(const PositionInComposedTree& position, EditingBoundaryCrossingRule rule)
+PositionInComposedTree mostForwardCaretPosition(const PositionInComposedTree& position, EditingBoundaryCrossingRule rule)
{
- return mostBackwardCaretPosition<EditingInComposedTreeStrategy>(position, rule);
+ return mostForwardCaretPosition<EditingInComposedTreeStrategy>(position, rule);
}
}
« no previous file with comments | « Source/core/editing/VisibleUnits.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698