Devtools: [LayoutEditor] highlight changed value in the SSP

Source/core/inspector/InspectorCSSAgent.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 1618 matching lines @@
             foundIndex = properties.size() - i - 1;
 
         if (property.important)
             break;
     }
 
     SourceRange bodyRange = sourceData->ruleBodyRange;
     String styleSheetText;
     inspectorStyleSheet->getText(&styleSheetText);
     String styleText = styleSheetText.substring(bodyRange.start, bodyRange.length());
-
+    SourceRange changeRange;
     if (foundIndex == -1) {
         bool isImportant = inlineStyle->getPropertyPriority(longhand) == "important";
         String newPropertyText = "\n" + longhand + ": " + value + (isImportant ? " !important" : "") + ";";
-        if (!styleText.stripWhiteSpace().endsWith(';'))
+        if (!styleText.isEmpty() && !styleText.stripWhiteSpace().endsWith(';'))
             newPropertyText = ";" + newPropertyText;
         styleText.append(newPropertyText);
+        changeRange.start = bodyRange.end;
+        changeRange.end = bodyRange.end + newPropertyText.length();
     } else {
         CSSPropertySourceData declaration = properties[foundIndex];
         String newValueText;
         if (declaration.name == shorthand)
             newValueText = createShorthandValue(ownerDocument, shorthand, declaration.value, longhand, value);
         else
             newValueText = value;
 
         String newPropertyText = declaration.name + ": " + newValueText + (declaration.important ? " !important" : "") + ";";
         styleText.replace(declaration.range.start - bodyRange.start, declaration.range.length(), newPropertyText);
+        changeRange.start = declaration.range.start;
+        changeRange.end = changeRange.start + newPropertyText.length();
     }
-    setStyleText(errorString, inspectorStyleSheet, bodyRange, styleText);
+    CSSStyleDeclaration* resultStyle = setStyleText(errorString, inspectorStyleSheet, bodyRange, styleText);
+    if (resultStyle)
+        frontend()->layoutEditorChange(inspectorStyleSheet->id(), inspectorStyleSheet->buildSourceRangeObject(changeRange));

[pfeldman, 2015/08/21 01:43:00]

You might need to flush stylesheetadded events.

[sergeyv, 2015/08/21 04:05:42]

Done.

 }
 
 void InspectorCSSAgent::setEffectivePropertyValueForNode(ErrorString* errorString, int nodeId, const String& propertyName, const String& value)
 {
     Element* element = elementForId(errorString, nodeId);
     if (!element)
         return;
 
     CSSPropertyID property = cssPropertyID(propertyName);
     if (!property) {
@@ skipping 16 matching lines @@
     visitor->trace(m_documentToCSSStyleSheets);
     visitor->trace(m_invalidatedDocuments);
     visitor->trace(m_nodeToInspectorStyleSheet);
     visitor->trace(m_documentToViaInspectorStyleSheet);
 #endif
     visitor->trace(m_inspectorUserAgentStyleSheet);
     InspectorBaseAgent::trace(visitor);
 }
 
 } // namespace blink