Issue 131043003: [import] Refactoring: Get rid of HTMLImport::isProcessing()

Issue 131043003: [import] Refactoring: Get rid of HTMLImport::isProcessing() (Closed)

Created:
6 years, 11 months ago by Hajime Morrita

Modified:
6 years, 11 months ago

Reviewers:
dominicc (has gone to gerrit), dglazkov1

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[import] Refactoring: Get rid of HTMLImport::isProcessing() This change eliminates confusing isProcessing() and exposes ownsLoader() instead. It clarify the logic in HTMLImport::isBlockingFollowersFromRunningScript(). BUG=none TEST=none R=dglazkov,dominicc Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164854

Patch Set 1 #

Patch Set 2 : Updated to Tot. #

Patch Set 3 : Fixed test failures #

Patch Set 4 : Fixed test failures #

Patch Set 5 : Updated #

Total comments: 1

Patch Set 6 : Removed an extra blank line #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -15 lines)			Patch
M	Source/core/html/HTMLImport.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLImport.cpp	View	1 2	3 chunks	+11 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLImportChild.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLImportChild.cpp	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/HTMLImportsController.h	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLImportsController.cpp	View	1 2 3 4	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dominicc (has gone to gerrit)

LGTM https://codereview.chromium.org/131043003/diff/140001/Source/core/html/HTMLImport.h File Source/core/html/HTMLImport.h (right): https://codereview.chromium.org/131043003/diff/140001/Source/core/html/HTMLImport.h#newcode170 Source/core/html/HTMLImport.h:170: Seems like there's excessive whitespace here.

6 years, 11 months ago (2014-01-10 06:44:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/131043003/210001

6 years, 11 months ago (2014-01-10 07:03:36 UTC) #4

Message was sent while issue was closed.

Change committed as 164854

Expand Messages | Collapse Messages