Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1310423003: Revert of MSE: Verify MediaLog events created by existing WebM unit tests (Closed)

Created:
5 years, 4 months ago by wolenetz
Modified:
5 years, 4 months ago
Reviewers:
chcunningham, xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MSE: Verify MediaLog events created by existing WebM unit tests (patchset #3 id:40001 of https://codereview.chromium.org/1300943002/ ) Reason for revert: This is breaking windows bots (http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/41148). Original issue's description: > MSE: Verify MediaLog events created by existing WebM unit tests > > Similar to previous SourceBufferStreamTests update in r342861, this > change updates media unit tests to provide a StrictMock<MockMediaLog> to > verify MediaLog events produced with existing MSE WebM unit tests. While > log message maintenance burden is increased, helpers are included to > reduce that burden while gaining improved resilience against logging > regression. > > This CL does not verify all possible MSE WebM parser MEDIA_LOGs, just > those that are emitted by existing unit tests. > > TEST=no regression > > Committed: https://crrev.com/b48815ca35b565e6ca372640ac25f79ee1a84c7e > Cr-Commit-Position: refs/heads/master@{#345181} TBR=xhwang@chromium.org,chcunningham@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/57f068f83e605fe5493f2785e3769162f4cd713e Cr-Commit-Position: refs/heads/master@{#345206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -307 lines) Patch
M media/base/mock_media_log.h View 1 chunk +0 lines, -10 lines 0 comments Download
M media/filters/source_buffer_stream_unittest.cc View 22 chunks +28 lines, -23 lines 0 comments Download
M media/formats/webm/webm_cluster_parser.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M media/formats/webm/webm_cluster_parser_unittest.cc View 22 chunks +80 lines, -171 lines 0 comments Download
M media/formats/webm/webm_content_encodings_client_unittest.cc View 8 chunks +3 lines, -48 lines 0 comments Download
M media/formats/webm/webm_tracks_parser_unittest.cc View 8 chunks +36 lines, -44 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wolenetz
Created Revert of MSE: Verify MediaLog events created by existing WebM unit tests
5 years, 4 months ago (2015-08-24 23:37:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310423003/1
5 years, 4 months ago (2015-08-24 23:37:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-24 23:38:28 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/57f068f83e605fe5493f2785e3769162f4cd713e Cr-Commit-Position: refs/heads/master@{#345206}
5 years, 4 months ago (2015-08-24 23:39:09 UTC) #4
wolenetz
5 years, 4 months ago (2015-08-25 19:21:51 UTC) #5
Message was sent while issue was closed.
On 2015/08/24 23:39:09, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/57f068f83e605fe5493f2785e3769162f4cd713e
> Cr-Commit-Position: refs/heads/master@{#345206}

Reland attempt of a fixed version of the original CL is at
https://codereview.chromium.org/1306923004/

Powered by Google App Engine
This is Rietveld 408576698