Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5366)

Unified Diff: chrome/browser/ui/sync/browser_synced_window_delegate.cc

Issue 1310373009: [Sync] Remove static methods on SyncedWindowDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/browser_synced_window_delegate.cc
diff --git a/chrome/browser/ui/sync/browser_synced_window_delegate.cc b/chrome/browser/ui/sync/browser_synced_window_delegate.cc
index 8b7231e9d46722ba7b4dcc06ee3023d1bacdf9f2..b53922b537486b45b9f74956a62663998d85bc1a 100644
--- a/chrome/browser/ui/sync/browser_synced_window_delegate.cc
+++ b/chrome/browser/ui/sync/browser_synced_window_delegate.cc
@@ -13,27 +13,6 @@
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "components/sessions/session_id.h"
-// static SyncedWindowDelegate implementations
-
-namespace browser_sync {
-
-// static
-std::set<const SyncedWindowDelegate*> SyncedWindowDelegate::GetAll() {
- std::set<const SyncedWindowDelegate*> synced_window_delegates;
- BrowserSyncedWindowDelegate::GetAllHelper(&synced_window_delegates);
- return synced_window_delegates;
-}
-
-// static
-const SyncedWindowDelegate* SyncedWindowDelegate::FindById(
- SessionID::id_type id) {
- const SyncedWindowDelegate* synced_window_delegate =
- BrowserSyncedWindowDelegate::FindByIdHelper(id);
- return synced_window_delegate;
-}
-
-} // namespace browser_sync
-
// BrowserSyncedWindowDelegate implementations
BrowserSyncedWindowDelegate::BrowserSyncedWindowDelegate(Browser* browser)
@@ -41,21 +20,6 @@ BrowserSyncedWindowDelegate::BrowserSyncedWindowDelegate(Browser* browser)
BrowserSyncedWindowDelegate::~BrowserSyncedWindowDelegate() {}
-// static
-void BrowserSyncedWindowDelegate::GetAllHelper(
- std::set<const browser_sync::SyncedWindowDelegate*>* delegates) {
- // Add all the browser windows.
- for (chrome::BrowserIterator it; !it.done(); it.Next())
- delegates->insert(it->synced_window_delegate());
-}
-
-// static
-const browser_sync::SyncedWindowDelegate*
-BrowserSyncedWindowDelegate::FindByIdHelper(SessionID::id_type id) {
- Browser* browser = chrome::FindBrowserWithID(id);
- return (browser != NULL) ? browser->synced_window_delegate() : NULL;
-}
-
bool BrowserSyncedWindowDelegate::IsTabPinned(
const browser_sync::SyncedTabDelegate* tab) const {
for (int i = 0; i < browser_->tab_strip_model()->count(); i++) {

Powered by Google App Engine
This is Rietveld 408576698