Add cr_policy_indicator for settings controls

chrome/browser/resources/settings/prefs/prefs.js

 /* Copyright 2015 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file. */
 
 /**
  * @fileoverview
  * 'cr-settings-prefs' models Chrome settings and preferences, listening for
  * changes to Chrome prefs whitelisted in chrome.settingsPrivate.
  * When changing prefs in this element's 'prefs' property via the UI, this
  * element tries to set those preferences in Chrome. Whether or not the calls to
@@ skipping 218 matching lines @@
     },
 
     /**
      * Sets or updates the pref denoted by newPrefObj.key in the publicy exposed
      * |prefs| property.
      * @param {chrome.settingsPrivate.PrefObject} newPrefObj The pref object to
      *     update the pref with.
      * @private
      */
     setPref_: function(newPrefObj) {
-      // Check if the pref exists already in the Polymer |prefs| object.
-      if (this.get(newPrefObj.key, this.prefs)) {
-        // Update just the value, notifying listeners of the change.
-        this.set('prefs.' + newPrefObj.key + '.value', newPrefObj.value);
-      } else {
-        // Add the pref to |prefs|. cr.exportPath doesn't use Polymer.Base.set,
-        // which is OK because the nested property update events aren't useful.
-        cr.exportPath(newPrefObj.key, newPrefObj, this.prefs);
-        // Notify listeners of the change at the preference key.
-        this.notifyPath('prefs.' + newPrefObj.key, newPrefObj);
-      }
+      // Add the pref object to |prefs| if necessary and set it. Note: we need
+      // to always set the entire object, not just the value, in case any policy
+      // or other attributes change.
+      cr.exportPath(newPrefObj.key, newPrefObj, this.prefs);
+      // Notify listeners of the change at the preference key.
+      this.notifyPath('prefs.' + newPrefObj.key, newPrefObj);

[michaelpg, 2015/09/16 18:58:52]

You'll need to rebase this on https://codereview.chromium.org/1346833003/ (or
rather, you can just remove this change and that CL does it for you).

[stevenjb, 2015/09/16 21:33:53]

Acknowledged.

     },
 
     /**
      * Creates a PrefWrapper object from a chrome.settingsPrivate pref.
      * @param {!chrome.settingsPrivate.PrefObject} prefObj
      *     PrefObject received from chrome.settingsPrivate.
      * @return {PrefWrapper} An object containing a copy of the PrefObject's
      *     value.
      * @private
      */
     createPrefWrapper_: function(prefObj) {
       return prefObj.type == chrome.settingsPrivate.PrefType.LIST ?
           new ListPrefWrapper(prefObj) : new PrefWrapper(prefObj);
     },
   });
 })();