Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 1310373005: Doc style: writing_clang_plugins.md (Closed)

Created:
5 years, 4 months ago by nodir
Modified:
5 years, 4 months ago
Reviewers:
Bons
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Doc style: writing_clang_plugins.md Fixed style R=andybons@chromium.org BUG=524256 Committed: https://crrev.com/e7e901b0e4d96bc629e0ce6223a284c4a5dec498 Cr-Commit-Position: refs/heads/master@{#345329}

Patch Set 1 #

Total comments: 2

Patch Set 2 : clang.md #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -44 lines) Patch
M docs/writing_clang_plugins.md View 1 3 chunks +100 lines, -44 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
nodir
https://codereview.chromium.org/1310373005/diff/1/docs/writing_clang_plugins.md File docs/writing_clang_plugins.md (right): https://codereview.chromium.org/1310373005/diff/1/docs/writing_clang_plugins.md#newcode8 docs/writing_clang_plugins.md:8: [does not exist in Gitiles](https://chromium.googlesource.com/src/third_party/llvm/). I don't know where ...
5 years, 4 months ago (2015-08-24 22:55:30 UTC) #1
Bons
lgtm https://codereview.chromium.org/1310373005/diff/1/docs/writing_clang_plugins.md File docs/writing_clang_plugins.md (right): https://codereview.chromium.org/1310373005/diff/1/docs/writing_clang_plugins.md#newcode8 docs/writing_clang_plugins.md:8: [does not exist in Gitiles](https://chromium.googlesource.com/src/third_party/llvm/). On 2015/08/24 22:55:30, ...
5 years, 4 months ago (2015-08-25 00:38:27 UTC) #2
nodir
On 2015/08/25 00:38:27, Bons wrote: > lgtm > > https://codereview.chromium.org/1310373005/diff/1/docs/writing_clang_plugins.md > File docs/writing_clang_plugins.md (right): > ...
5 years, 4 months ago (2015-08-25 14:49:09 UTC) #5
Bons
yes On Tue, Aug 25, 2015 at 10:49 AM <nodir@chromium.org> wrote: > On 2015/08/25 00:38:27, ...
5 years, 4 months ago (2015-08-25 15:17:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310373005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310373005/20001
5 years, 4 months ago (2015-08-25 15:21:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-25 15:30:17 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 15:31:10 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e7e901b0e4d96bc629e0ce6223a284c4a5dec498
Cr-Commit-Position: refs/heads/master@{#345329}

Powered by Google App Engine
This is Rietveld 408576698