Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2113)

Unified Diff: Source/devtools/front_end/sdk/TracingModel.js

Issue 1310343007: DevTools: fix 'Failed to write into a temp file' when recording a filmstrip (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/network/NetworkPanel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/TracingModel.js
diff --git a/Source/devtools/front_end/sdk/TracingModel.js b/Source/devtools/front_end/sdk/TracingModel.js
index 5aa30abf199c8827f4b1ad3223c0489b9bf440fe..b102c689dcebfc88798b428caa4a400ac5ca68c1 100644
--- a/Source/devtools/front_end/sdk/TracingModel.js
+++ b/Source/devtools/front_end/sdk/TracingModel.js
@@ -10,8 +10,10 @@
*/
WebInspector.TracingModel = function(backingStorage)
{
- this._backingStorage = backingStorage;
this.reset();
+ // Set backing storage after reset so that we do not perform
+ // an extra reset of backing storage -- this is not free.
+ this._backingStorage = backingStorage;
}
/**
@@ -190,7 +192,8 @@ WebInspector.TracingModel.prototype = {
this._minimumRecordTime = 0;
this._maximumRecordTime = 0;
this._devToolsMetadataEvents = [];
- this._backingStorage.reset();
+ if (this._backingStorage)
+ this._backingStorage.reset();
this._appendDelimiter = false;
/** @type {!Array<!WebInspector.TracingModel.Event>} */
this._asyncEvents = [];
« no previous file with comments | « Source/devtools/front_end/network/NetworkPanel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698