Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1310343005: [Telemetry] Add pyfakefs to telemetry/third_party (Closed)

Created:
5 years, 3 months ago by nednguyen
Modified:
5 years, 3 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add pyfakefs to telemetry/third_party BUG about pyfakefs/setup.py's license header: https://github.com/jmcgeheeiv/pyfakefs/issues/50 BUG=527952 Committed: https://crrev.com/4f7f5c562951940a6be9a839cd338cc35ce0dbac Cr-Commit-Position: refs/heads/master@{#347292}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address Ethan's comment #

Patch Set 3 : Add license header to setup.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7789 lines, -14 lines) Patch
A tools/telemetry/third_party/pyfakefs/README.chromium View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A + tools/telemetry/third_party/pyfakefs/pyfakefs/.travis.yml View 2 chunks +11 lines, -16 lines 0 comments Download
A + tools/telemetry/third_party/pyfakefs/pyfakefs/COPYING View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/README.md View 1 chunk +51 lines, -0 lines 0 comments Download
A + tools/telemetry/third_party/pyfakefs/pyfakefs/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/all_tests.py View 1 chunk +47 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/example.py View 1 chunk +120 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/example_test.py View 1 chunk +137 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/fake_filesystem.py View 1 chunk +2202 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/fake_filesystem_glob.py View 1 chunk +120 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/fake_filesystem_glob_test.py View 1 chunk +82 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/fake_filesystem_shutil.py View 1 chunk +220 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/fake_filesystem_shutil_test.py View 1 chunk +305 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/fake_filesystem_test.py View 1 chunk +2925 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/fake_filesystem_unittest.py View 1 chunk +236 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/fake_filesystem_unittest_test.py View 1 chunk +103 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/fake_filesystem_vs_real_test.py View 1 chunk +612 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/fake_tempfile.py View 1 chunk +312 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/fake_tempfile_test.py View 1 chunk +197 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/requirements.txt View 1 chunk +1 line, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/setup.py View 1 2 1 chunk +85 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/pyfakefs/pyfakefs/tox.ini View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
nednguyen
5 years, 3 months ago (2015-09-03 17:36:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310343005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310343005/1
5 years, 3 months ago (2015-09-03 17:38:00 UTC) #4
eakuefner
lgtm! Excited to make use of this! https://codereview.chromium.org/1310343005/diff/1/tools/telemetry/third_party/pyfakefs/README.chromium File tools/telemetry/third_party/pyfakefs/README.chromium (right): https://codereview.chromium.org/1310343005/diff/1/tools/telemetry/third_party/pyfakefs/README.chromium#newcode3 tools/telemetry/third_party/pyfakefs/README.chromium:3: URL: https://github.com/jmcgeheeiv/pyfakefs, ...
5 years, 3 months ago (2015-09-03 17:51:14 UTC) #5
nednguyen
good catch on the LICENSE file https://codereview.chromium.org/1310343005/diff/1/tools/telemetry/third_party/pyfakefs/README.chromium File tools/telemetry/third_party/pyfakefs/README.chromium (right): https://codereview.chromium.org/1310343005/diff/1/tools/telemetry/third_party/pyfakefs/README.chromium#newcode3 tools/telemetry/third_party/pyfakefs/README.chromium:3: URL: https://github.com/jmcgeheeiv/pyfakefs, https://code.google.com/p/pyfakefs/ ...
5 years, 3 months ago (2015-09-03 17:55:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310343005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310343005/20001
5 years, 3 months ago (2015-09-03 17:56:27 UTC) #9
aiolos (Not reviewing)
lgtm. Yay!
5 years, 3 months ago (2015-09-03 18:14:32 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/107888)
5 years, 3 months ago (2015-09-03 18:56:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310343005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310343005/20001
5 years, 3 months ago (2015-09-03 19:08:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310343005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310343005/40001
5 years, 3 months ago (2015-09-03 22:57:40 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-04 00:05:39 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 00:07:04 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4f7f5c562951940a6be9a839cd338cc35ce0dbac
Cr-Commit-Position: refs/heads/master@{#347292}

Powered by Google App Engine
This is Rietveld 408576698