Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 131033004: DevTools: introduce goto-column functionality (Closed)

Created:
6 years, 11 months ago by lushnikov
Modified:
6 years, 10 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: introduce goto-column functionality This patch adds goto-column functionality to Ctrl-O dialog. BUG=337909 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165948

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Total comments: 2

Patch Set 3 : trimRight => trim #

Patch Set 4 : unforseen changes #

Total comments: 2

Patch Set 5 : removed spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -23 lines) Patch
M Source/devtools/front_end/CodeMirrorTextEditor.js View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/devtools/front_end/FilteredItemSelectionDialog.js View 1 2 3 4 9 chunks +28 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
lushnikov
please take a look
6 years, 11 months ago (2014-01-27 12:14:15 UTC) #1
vsevik
https://chromiumcodereview.appspot.com/131033004/diff/1/Source/devtools/front_end/FilteredItemSelectionDialog.js File Source/devtools/front_end/FilteredItemSelectionDialog.js (left): https://chromiumcodereview.appspot.com/131033004/diff/1/Source/devtools/front_end/FilteredItemSelectionDialog.js#oldcode716 Source/devtools/front_end/FilteredItemSelectionDialog.js:716: if (/^:\d+$/.test(promptValue.trimRight())) { Let's keep trimRight https://chromiumcodereview.appspot.com/131033004/diff/1/Source/devtools/front_end/FilteredItemSelectionDialog.js File Source/devtools/front_end/FilteredItemSelectionDialog.js ...
6 years, 11 months ago (2014-01-27 17:19:10 UTC) #2
vsevik
lgtm
6 years, 11 months ago (2014-01-27 17:19:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/131033004/1
6 years, 10 months ago (2014-01-28 12:46:38 UTC) #4
lushnikov
https://codereview.chromium.org/131033004/diff/1/Source/devtools/front_end/FilteredItemSelectionDialog.js File Source/devtools/front_end/FilteredItemSelectionDialog.js (left): https://codereview.chromium.org/131033004/diff/1/Source/devtools/front_end/FilteredItemSelectionDialog.js#oldcode716 Source/devtools/front_end/FilteredItemSelectionDialog.js:716: if (/^:\d+$/.test(promptValue.trimRight())) { On 2014/01/27 17:19:11, vsevik wrote: > ...
6 years, 10 months ago (2014-01-28 13:27:07 UTC) #5
lushnikov
vsevik, please take another look on this as some unforeseen changes happened
6 years, 10 months ago (2014-01-28 13:55:58 UTC) #6
vsevik
https://codereview.chromium.org/131033004/diff/70001/Source/devtools/front_end/FilteredItemSelectionDialog.js File Source/devtools/front_end/FilteredItemSelectionDialog.js (right): https://codereview.chromium.org/131033004/diff/70001/Source/devtools/front_end/FilteredItemSelectionDialog.js#newcode718 Source/devtools/front_end/FilteredItemSelectionDialog.js:718: if (!parsedExpression) I don't think this ever happens! https://codereview.chromium.org/131033004/diff/100001/Source/devtools/front_end/FilteredItemSelectionDialog.js ...
6 years, 10 months ago (2014-01-28 14:45:40 UTC) #7
vsevik
lgtm
6 years, 10 months ago (2014-01-28 14:45:48 UTC) #8
lushnikov
https://codereview.chromium.org/131033004/diff/70001/Source/devtools/front_end/FilteredItemSelectionDialog.js File Source/devtools/front_end/FilteredItemSelectionDialog.js (right): https://codereview.chromium.org/131033004/diff/70001/Source/devtools/front_end/FilteredItemSelectionDialog.js#newcode718 Source/devtools/front_end/FilteredItemSelectionDialog.js:718: if (!parsedExpression) On 2014/01/28 14:45:41, vsevik wrote: > I ...
6 years, 10 months ago (2014-01-28 15:15:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/131033004/120001
6 years, 10 months ago (2014-01-28 15:15:18 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-01-28 17:32:28 UTC) #11
Message was sent while issue was closed. 
Change committed as 165948

Powered by Google App Engine
This is Rietveld 408576698