Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 131033002: Mojo: Simplify object serialization (Closed)

Created:
6 years, 11 months ago by darin (slow to review)
Modified:
6 years, 11 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Simplify object serialization Eliminate ObjectTraits<T> classes in favor of putting these methods directly on the generated *_Data classes. ObjectTraits<T> was added to hide these methods from public classes, but now that *_Data classes are internal, there is no longer any need for ObjectTraits<T>. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244071

Patch Set 1 #

Patch Set 2 : fix indentation error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -336 lines) Patch
M mojo/public/bindings/generators/cpp_templates/interface_definition.tmpl View 4 chunks +8 lines, -8 lines 0 comments Download
M mojo/public/bindings/generators/cpp_templates/module.cc.tmpl View 3 chunks +6 lines, -24 lines 0 comments Download
M mojo/public/bindings/generators/cpp_templates/module_internal.h.tmpl View 2 chunks +1 line, -12 lines 0 comments Download
M mojo/public/bindings/generators/cpp_templates/params_definition.tmpl View 1 chunk +16 lines, -2 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/params_serialization.tmpl View 1 chunk +0 lines, -25 lines 0 comments Download
M mojo/public/bindings/generators/cpp_templates/struct_declaration.tmpl View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/public/bindings/generators/cpp_templates/struct_definition.tmpl View 2 chunks +43 lines, -0 lines 0 comments Download
M mojo/public/bindings/generators/cpp_templates/struct_macros.tmpl View 1 chunk +6 lines, -6 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/struct_serialization_definition.tmpl View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/struct_serialization_traits.tmpl View 1 chunk +0 lines, -14 lines 0 comments Download
M mojo/public/bindings/lib/array_internal.h View 1 3 chunks +126 lines, -2 lines 0 comments Download
M mojo/public/bindings/lib/array_internal.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M mojo/public/bindings/lib/bindings_serialization.h View 3 chunks +3 lines, -166 lines 0 comments Download
M mojo/public/bindings/lib/bindings_serialization.cc View 2 chunks +2 lines, -21 lines 0 comments Download
M mojo/public/bindings/mojom_bindings_generator.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
darin (slow to review)
6 years, 11 months ago (2014-01-09 07:28:45 UTC) #1
Matt Perry
lgtm
6 years, 11 months ago (2014-01-09 20:59:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/131033002/30001
6 years, 11 months ago (2014-01-09 21:07:21 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 03:36:06 UTC) #4
Message was sent while issue was closed.
Change committed as 244071

Powered by Google App Engine
This is Rietveld 408576698