Merge duplicate code in invalidation helper.

sync/tools/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//testing/test.gni")
 
 if (is_linux && !is_chromeos) {
   # TODO(GYP): Figure out which of these work and are needed on other platforms.
   source_set("common") {
     testonly = true
 
     sources = [
-      "invalidation_helper.cc",
-      "invalidation_helper.h",
       "null_invalidation_state_tracker.cc",
       "null_invalidation_state_tracker.h",
     ]
 
     deps = [
       "//base",
       "//components/invalidation/impl",
       "//sync",

[droger, 2015/09/21 07:17:11]

Looks like there is a missing dependency on //components/sync_driver.

[Jitu( very slow this week), 2015/09/21 13:03:22]

Done.

     ]
   }
 
   test("sync_listen_notifications") {
     sources = [
       "sync_listen_notifications.cc",
     ]
 
     defines = [ "SYNC_TEST" ]
 
     deps = [
       ":common",
       "//base",
       "//components/invalidation/impl",

[droger, 2015/09/21 07:18:07]

And probably here too.

[Jitu( very slow this week), 2015/09/21 13:03:22]

I think only adding in above place is fine, as already this target depends on
:common

[droger, 2015/09/21 13:11:13]

You are right that it will compile.

However, the recommendation is to always explicitly list the depedencies that
are needed, and not rely on transitive dependencies.
Since sync_listen_notifications.cc has includes in sync_driver, the dependency
should be added here too.

The benefit of this, is that if somebody removes the dependency in :common in
the future, this target will not break.


This is similar to the practice for #includes directives: we always include what
we use and don't rely on transitive #includes.

       "//jingle:notifier",
       "//net",
       "//net:test_support",
       "//sync",
       "//sync:test_support_sync_core",
     ]
   }
 
   test("sync_client") {
     sources = [
       "sync_client.cc",
     ]
 
     defines = [ "SYNC_TEST" ]
 
     deps = [
       ":common",
       "//base",
       "//components/invalidation/impl",
       "//jingle:notifier",
       "//net",
       "//net:test_support",
       "//sync",
       "//sync:test_support_sync_core",
     ]
   }
 }