sync/util/invalidation_helper.h - Issue 1310323009: Merge duplicate code in invalidation helper.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sync/util/invalidation_helper.h

Issue 1310323009: Merge duplicate code in invalidation helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef SYNC_TOOLS_INVALIDATION_HELPER_H_	5 #ifndef SYNC_TOOLS_INVALIDATION_HELPER_H_

6 #define SYNC_TOOLS_INVALIDATION_HELPER_H_	6 #define SYNC_TOOLS_INVALIDATION_HELPER_H_

7	7

8 #include "components/invalidation/public/invalidation_util.h"	8 #include "components/invalidation/public/invalidation_util.h"
	droger 2015/09/09 08:29:08 Is this include necessary? If we can't remove, ca Is this include necessary? If we can't remove, can we replace by: namespace invalidation { class ObjectId; } Jitu( very slow this week) 2015/09/09 09:59:04 Including ObjectId is look good. But how about "O Show quoted text On 2015/09/09 08:29:08, droger wrote: > Is this include necessary? > > If we can't remove, can we replace by: > > namespace invalidation { > class ObjectId; > } Including ObjectId is look good. But how about "ObjectIdSet" droger 2015/09/09 10:59:14 Right, we have to include the file, at least in th Show quoted text On 2015/09/09 09:59:04, jitu wrote: > On 2015/09/09 08:29:08, droger wrote: > > Is this include necessary? > > > > If we can't remove, can we replace by: > > > > namespace invalidation { > > class ObjectId; > > } > > Including ObjectId is look good. > > But how about "ObjectIdSet" Right, we have to include the file, at least in the .cc. You can keep it as is then.
9 #include "google/cacheinvalidation/include/types.h"	9 #include "google/cacheinvalidation/include/types.h"

10 #include "sync/internal_api/public/base/model_type.h"	10 #include "sync/internal_api/public/base/model_type.h"

11	11

12 namespace syncer {	12 namespace syncer {

13	13

14 bool RealModelTypeToObjectId(ModelType model_type,	14 bool RealModelTypeToObjectId(ModelType model_type,

15 invalidation::ObjectId* object_id);	15 invalidation::ObjectId* object_id);

16	16

17 ObjectIdSet ModelTypeSetToObjectIdSet(ModelTypeSet model_types);	17 ObjectIdSet ModelTypeSetToObjectIdSet(ModelTypeSet model_types);

18	18

19 }	19 }

20	20

21 #endif // SYNC_TOOLS_INVALIDATION_HELPER_H	21 #endif // SYNC_TOOLS_INVALIDATION_HELPER_H

OLD	NEW

« sync/sync.gyp ('K') | « sync/util/DEPS ('k') | sync/util/invalidation_helper.cc » ('j') | no next file with comments »