sync/util/invalidation_helper.cc - Issue 1310323009: Merge duplicate code in invalidation helper.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sync/util/invalidation_helper.cc

Issue 1310323009: Merge duplicate code in invalidation helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "sync/tools/invalidation_helper.h"	5 #include "sync/util/invalidation_helper.h"

6	6

7 #include "google/cacheinvalidation/types.pb.h"	7 #include "google/cacheinvalidation/types.pb.h"

8	8

9 namespace syncer {	9 namespace syncer {

10	10

11 bool RealModelTypeToObjectId(ModelType model_type,	11 bool RealModelTypeToObjectId(ModelType model_type,

12 invalidation::ObjectId* object_id) {	12 invalidation::ObjectId* object_id) {

13 std::string notification_type;	13 std::string notification_type;

14 if (!RealModelTypeToNotificationType(model_type, &notification_type)) {	14 if (!RealModelTypeToNotificationType(model_type, &notification_type)) {

15 return false;	15 return false;

(...skipping 10 matching lines...) Expand all Loading...
26 if (!RealModelTypeToObjectId(it.Get(), &model_type_as_id)) {	26 if (!RealModelTypeToObjectId(it.Get(), &model_type_as_id)) {

27 DLOG(WARNING) << "Invalid model type " << it.Get();	27 DLOG(WARNING) << "Invalid model type " << it.Get();

28 continue;	28 continue;

29 }	29 }

30 ids.insert(model_type_as_id);	30 ids.insert(model_type_as_id);

31 }	31 }

32 return ids;	32 return ids;

33 }	33 }

34	34

35 } // namespace syncer	35 } // namespace syncer

OLD	NEW