Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1978)

Issue 1310323006: [turbofan] support for Int64 in CheckedLoad/CheckedStore on 64-bit platforms. (Closed)

Created:
5 years, 3 months ago by titzer
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] support for Int64 in CheckedLoad/CheckedStore on 64-bit platforms. This is to support WebAssembly 64-bit ints in the short term, since it currently uses CheckedLoad/CheckedStore for accesses to the memory. In the long run, we'll change this to be explicit bounds checks that throw on out of bounds. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/963d664581e09d7846196b127f1fce845b9bc4a4 Cr-Commit-Position: refs/heads/master@{#30555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -1 line) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 4 chunks +34 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +45 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 3 months ago (2015-09-03 09:15:49 UTC) #1
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-03 10:42:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310323006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310323006/1
5 years, 3 months ago (2015-09-03 10:43:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 10:45:42 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 10:46:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/963d664581e09d7846196b127f1fce845b9bc4a4
Cr-Commit-Position: refs/heads/master@{#30555}

Powered by Google App Engine
This is Rietveld 408576698