Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: Source/core/dom/Element.h

Issue 1310323003: Update Element methods for root layer scrolling. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address review comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2003-2011, 2013, 2014 Apple Inc. All rights reserved. 6 * Copyright (C) 2003-2011, 2013, 2014 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 542 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 void classAttributeChanged(const AtomicString& newClassString); 553 void classAttributeChanged(const AtomicString& newClassString);
554 554
555 static bool attributeValueIsJavaScriptURL(const Attribute&); 555 static bool attributeValueIsJavaScriptURL(const Attribute&);
556 556
557 PassRefPtr<ComputedStyle> originalStyleForLayoutObject(); 557 PassRefPtr<ComputedStyle> originalStyleForLayoutObject();
558 558
559 Node* insertAdjacent(const String& where, Node* newChild, ExceptionState&); 559 Node* insertAdjacent(const String& where, Node* newChild, ExceptionState&);
560 560
561 virtual void parserDidSetAttributes() { } 561 virtual void parserDidSetAttributes() { }
562 562
563 private:
563 void scrollLayoutBoxBy(const ScrollToOptions&); 564 void scrollLayoutBoxBy(const ScrollToOptions&);
564 void scrollLayoutBoxTo(const ScrollToOptions&); 565 void scrollLayoutBoxTo(const ScrollToOptions&);
565 void scrollFrameBy(const ScrollToOptions&); 566 void scrollFrameBy(const ScrollToOptions&);
566 void scrollFrameTo(const ScrollToOptions&); 567 void scrollFrameTo(const ScrollToOptions&);
567 568
568 private:
569 bool hasElementFlag(ElementFlags mask) const { return hasRareData() && hasEl ementFlagInternal(mask); } 569 bool hasElementFlag(ElementFlags mask) const { return hasRareData() && hasEl ementFlagInternal(mask); }
570 void setElementFlag(ElementFlags, bool value = true); 570 void setElementFlag(ElementFlags, bool value = true);
571 void clearElementFlag(ElementFlags); 571 void clearElementFlag(ElementFlags);
572 bool hasElementFlagInternal(ElementFlags) const; 572 bool hasElementFlagInternal(ElementFlags) const;
573 573
574 bool isElementNode() const = delete; // This will catch anyone doing an unne cessary check. 574 bool isElementNode() const = delete; // This will catch anyone doing an unne cessary check.
575 bool isDocumentFragment() const = delete; // This will catch anyone doing an unnecessary check. 575 bool isDocumentFragment() const = delete; // This will catch anyone doing an unnecessary check.
576 bool isDocumentNode() const = delete; // This will catch anyone doing an unn ecessary check. 576 bool isDocumentNode() const = delete; // This will catch anyone doing an unn ecessary check.
577 577
578 void styleAttributeChanged(const AtomicString& newStyleString, AttributeModi ficationReason); 578 void styleAttributeChanged(const AtomicString& newStyleString, AttributeModi ficationReason);
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
896 static PassRefPtrWillBeRawPtr<T> create(const QualifiedName&, Document&) 896 static PassRefPtrWillBeRawPtr<T> create(const QualifiedName&, Document&)
897 #define DEFINE_ELEMENT_FACTORY_WITH_TAGNAME(T) \ 897 #define DEFINE_ELEMENT_FACTORY_WITH_TAGNAME(T) \
898 PassRefPtrWillBeRawPtr<T> T::create(const QualifiedName& tagName, Document& document) \ 898 PassRefPtrWillBeRawPtr<T> T::create(const QualifiedName& tagName, Document& document) \
899 { \ 899 { \
900 return adoptRefWillBeNoop(new T(tagName, document)); \ 900 return adoptRefWillBeNoop(new T(tagName, document)); \
901 } 901 }
902 902
903 } // namespace 903 } // namespace
904 904
905 #endif // Element_h 905 #endif // Element_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/scrolling/html-element-client-rect-excludes-scrollbars-expected.txt ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698