[Chromecast] Move SynchronizedMinidumpManager ratelimit logic to child classes.

chromecast/crash/linux/minidump_writer_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <fstream>
 
 #include "base/base_paths.h"
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
@@ skipping 103 matching lines @@
 }
 
 TEST_F(MinidumpWriterTest, Write_FailsWithSubdirInCorrectPath) {
   MinidumpWriter writer(&fake_generator_,
                         dumplog_file_.Append("subdir/logfile").value(),
                         MinidumpParams(),
                         base::Bind(&FakeDumpState));
   ASSERT_EQ(-1, writer.Write());
 }
 
-TEST_F(MinidumpWriterTest, Write_FailsWhenTooManyDumpsPresent) {

[slan, 2015/09/09 19:08:10]

Would you say that all of the test coverage removed here is replaced in
synchronized_minidump_manager_unittests?

[bcf_google, 2015/09/09 21:20:29]

Yes. These tests were actually testing SynchronizedMinidumpManager ratelimit
logic anyways.

-  MinidumpWriter writer(&fake_generator_,
-                        dumplog_file_.value(),
-                        MinidumpParams(),
-                        base::Bind(&FakeDumpState));
-
-  // Write dump logs to the lockfile.
-  size_t too_many_dumps = SynchronizedMinidumpManager::kMaxLockfileDumps + 1;
-  for (size_t i = 0; i < too_many_dumps; ++i) {
-    scoped_ptr<DumpInfo> info(CreateDumpInfo(
-        "{"
-        "\"name\": \"p\","
-        "\"dump_time\" : \"2012-01-01 01:02:03\","
-        "\"dump\": \"dump_string\","
-        "\"uptime\": \"123456789\","
-        "\"logfile\": \"logfile.log\""
-        "}"));
-    ASSERT_TRUE(info->valid());
-    ASSERT_TRUE(AppendLockFile(*info));
-  }
-
-  ASSERT_EQ(-1, writer.Write());
-}
-
-TEST_F(MinidumpWriterTest, Write_FailsWhenTooManyRecentDumpsPresent) {
-  MinidumpWriter writer(&fake_generator_,
-                        dumplog_file_.value(),
-                        MinidumpParams(),
-                        base::Bind(&FakeDumpState));
-  // Multiple iters to make sure period resets work correctly
-  for (int iter = 0; iter < 3; ++iter) {
-    time_t now = time(nullptr);
-
-    // Write dump logs to the lockfile.
-    size_t too_many_recent_dumps =
-        SynchronizedMinidumpManager::kRatelimitPeriodMaxDumps;
-    for (size_t i = 0; i < too_many_recent_dumps; ++i) {
-      ASSERT_EQ(0, writer.Write());
-
-      // Clear dumps so we don't reach max dumps in lockfile
-      ASSERT_TRUE(ClearDumps(lockfile_path_.value()));
-    }
-
-    // Should fail with too many dumps
-    ASSERT_EQ(-1, writer.Write());
-
-    int64 period = SynchronizedMinidumpManager::kRatelimitPeriodSeconds;
-
-    // Half period shouldn't trigger reset
-    SetRatelimitPeriodStart(metadata_path_.value(), now - period / 2);
-    ASSERT_EQ(-1, writer.Write());
-
-    // Set period starting time to trigger a reset
-    SetRatelimitPeriodStart(metadata_path_.value(), now - period);
-  }
-
-  ASSERT_EQ(0, writer.Write());
-}
-
-TEST_F(MinidumpWriterTest, Write_SucceedsWhenDumpLimitsNotExceeded) {
-  MinidumpWriter writer(&fake_generator_,
-                        dumplog_file_.value(),
-                        MinidumpParams(),
-                        base::Bind(&FakeDumpState));
-
-  ASSERT_GT(SynchronizedMinidumpManager::kMaxLockfileDumps, 1);
-  ASSERT_GT(SynchronizedMinidumpManager::kRatelimitPeriodMaxDumps, 0);
-
-  // Write an old dump logs to the lockfile.
-  scoped_ptr<DumpInfo> info(CreateDumpInfo(
-      "{"
-      "\"name\": \"p\","
-      "\"dump_time\" : \"2012-01-01 01:02:03\","
-      "\"dump\": \"dump_string\","
-      "\"uptime\": \"123456789\","
-      "\"logfile\": \"logfile.log\""
-      "}"));
-  ASSERT_TRUE(info->valid());
-  ASSERT_TRUE(AppendLockFile(*info));
-  ASSERT_EQ(0, writer.Write());
-}
-
 }  // namespace chromecast