Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1310303008: PPC: [runtime] Replace many buggy uses of %_CallFunction with %_Call. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [runtime] Replace many buggy uses of %_CallFunction with %_Call. Port db2ba190dba6983b94eae36e111b0feebb97587e Original commit message: The semantics of the %_CallFunction intrinsic seem to be very unclear, which resulted in a lot of bugs. Especially the combination with %IsSloppyModeFunction is always a bug, because the receiver would be wrapped in the wrong context. So the %IsSloppyModeFunction helper is gone now, and many of the buggy uses of %_CallFunction are also eliminated. If you ever need to call something with a different receiver, then %_Call is your friend now. It does what you want and implements the call sequence fully (and correct). R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=v8:4413 LOG=n Committed: https://crrev.com/50c6b031fd2a474e642865b37f4d5de3b4618ff8 Cr-Commit-Position: refs/heads/master@{#30655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +21 lines, -1 line 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 3 months ago (2015-09-08 22:23:52 UTC) #1
dstence
lgtm
5 years, 3 months ago (2015-09-09 13:34:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310303008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310303008/1
5 years, 3 months ago (2015-09-09 14:04:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 14:27:27 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 14:27:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50c6b031fd2a474e642865b37f4d5de3b4618ff8
Cr-Commit-Position: refs/heads/master@{#30655}

Powered by Google App Engine
This is Rietveld 408576698