Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1310303005: Revert of Fix buildbot console view in order_by_time mode (Closed)

Created:
5 years, 3 months ago by msw
Modified:
5 years, 3 months ago
Reviewers:
ricow1, agable
CC:
chromium-reviews, infra-reviews+build_chromium.org, kustermann
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Fix buildbot console view in order_by_time mode (patchset #2 id:20001 of https://codereview.chromium.org/1305053002/ ) Reason for revert: Causes build_presubmit errors: http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/ http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/builds/1332/steps/presubmit/logs/stdio ** Presubmit ERRORS ** Pylint (603 files using ['--disable=cyclic-import'] on 8 cores) (83.47s) failed ************* Module master.chromium_status_bb8 E:235,35: No value for argument 'revisions' in method call (no-value-for-parameter) Original issue's description: > Fix buildbot console view in order_by_time mode > > Applying a rebased version of http://trac.buildbot.net/ticket/2364 > > R=agable@chromium.org > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296438 TBR=agable@chromium.org,ricow@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -94 lines) Patch
M third_party/buildbot_8_4p1/README.chromium View 1 chunk +0 lines, -81 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/status/web/console.py View 7 chunks +6 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
msw
Created Revert of Fix buildbot console view in order_by_time mode
5 years, 3 months ago (2015-08-26 23:49:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310303005/1
5 years, 3 months ago (2015-08-26 23:49:41 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 23:49:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296443

Powered by Google App Engine
This is Rietveld 408576698