Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Issue 1310283004: Remove host_path_finder.py. (Closed)

Created:
5 years, 3 months ago by mikecase (-- gone --)
Modified:
5 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove host_path_finder.py. This module seems unused. It was initially used in one function, PurgeUnpinnedAshmem from android_commands.py which seems to be gone. This cleanup is part of my quest to remove code that contains "out/Debug" or "out/Release" explicitly. BUG= Committed: https://crrev.com/5be585002085bc2c95084d199c9cea58f66906ee Cr-Commit-Position: refs/heads/master@{#345930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
D build/android/pylib/utils/host_path_finder.py View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mikecase (-- gone --)
5 years, 3 months ago (2015-08-27 17:05:01 UTC) #2
jbudorick
lgtm
5 years, 3 months ago (2015-08-27 17:09:49 UTC) #3
jbudorick
On 2015/08/27 at 17:09:49, jbudorick wrote: > lgtm 'tis a noble quest
5 years, 3 months ago (2015-08-27 17:10:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310283004/1
5 years, 3 months ago (2015-08-27 17:13:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 18:34:44 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 18:35:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5be585002085bc2c95084d199c9cea58f66906ee
Cr-Commit-Position: refs/heads/master@{#345930}

Powered by Google App Engine
This is Rietveld 408576698