Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1310273009: Remove all gyp BUILD rules with multiple outputs. (Closed)

Created:
5 years, 3 months ago by vogelheim
Modified:
5 years, 3 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove all gyp BUILD rules with multiple outputs. - Modify js2c to accept --js and --nojs, - modify mksnapshot to accept --startup_src (instead of a positional parameter, so that it can be omitted), - modify v8.gyp to use the above so that no target has multiple output dependencies, and - update GN to use the switches above. (I have not succeeded in fixing the GYP->make translator to properly map multi-output rules, so that they work as expected in all edge cases. This CL signals defeat on that front, and instead I rewrite the GYP file to avoid that situation in the first place.) R=jochen@chromium.org BUG=v8:4382 LOG=N Committed: https://crrev.com/244cc0a6a9643bee962c2e3c60a1e093f18fe9ed Cr-Commit-Position: refs/heads/master@{#30640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -64 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/snapshot/mksnapshot.cc View 5 chunks +16 lines, -10 lines 0 comments Download
M tools/gyp/v8.gyp View 11 chunks +86 lines, -53 lines 0 comments Download
M tools/js2c.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
vogelheim
Please let me know whether the approach is acceptable. I have to admit defeat on ...
5 years, 3 months ago (2015-09-08 14:05:20 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-08 14:12:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310273009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310273009/1
5 years, 3 months ago (2015-09-08 15:23:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 15:24:50 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 15:25:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/244cc0a6a9643bee962c2e3c60a1e093f18fe9ed
Cr-Commit-Position: refs/heads/master@{#30640}

Powered by Google App Engine
This is Rietveld 408576698