Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: Source/devtools/protocol.json

Issue 1310273006: Devtools: convert pair of booleans in setInspectModeEnabled into enum parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/devtools/front_end/sdk/DOMModel.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 "version": { "major": "1", "minor": "1" }, 2 "version": { "major": "1", "minor": "1" },
3 "domains": [{ 3 "domains": [{
4 "domain": "Inspector", 4 "domain": "Inspector",
5 "hidden": true, 5 "hidden": true,
6 "types": [], 6 "types": [],
7 "commands": [ 7 "commands": [
8 { 8 {
9 "name": "enable", 9 "name": "enable",
10 "description": "Enables inspector domain notifications.", 10 "description": "Enables inspector domain notifications.",
(...skipping 2350 matching lines...) Expand 10 before | Expand all | Expand 10 after
2361 { "name": "displayAsMaterial", "type": "boolean", "optional" : true, "hidden": true}, 2361 { "name": "displayAsMaterial", "type": "boolean", "optional" : true, "hidden": true},
2362 { "name": "contentColor", "$ref": "RGBA", "optional": true, "description": "The content box highlight fill color (default: transparent)." }, 2362 { "name": "contentColor", "$ref": "RGBA", "optional": true, "description": "The content box highlight fill color (default: transparent)." },
2363 { "name": "paddingColor", "$ref": "RGBA", "optional": true, "description": "The padding highlight fill color (default: transparent)." }, 2363 { "name": "paddingColor", "$ref": "RGBA", "optional": true, "description": "The padding highlight fill color (default: transparent)." },
2364 { "name": "borderColor", "$ref": "RGBA", "optional": true, " description": "The border highlight fill color (default: transparent)." }, 2364 { "name": "borderColor", "$ref": "RGBA", "optional": true, " description": "The border highlight fill color (default: transparent)." },
2365 { "name": "marginColor", "$ref": "RGBA", "optional": true, " description": "The margin highlight fill color (default: transparent)." }, 2365 { "name": "marginColor", "$ref": "RGBA", "optional": true, " description": "The margin highlight fill color (default: transparent)." },
2366 { "name": "eventTargetColor", "$ref": "RGBA", "optional": tr ue, "hidden": true, "description": "The event target element highlight fill colo r (default: transparent)." }, 2366 { "name": "eventTargetColor", "$ref": "RGBA", "optional": tr ue, "hidden": true, "description": "The event target element highlight fill colo r (default: transparent)." },
2367 { "name": "shapeColor", "$ref": "RGBA", "optional": true, "h idden": true, "description": "The shape outside fill color (default: transparent )." }, 2367 { "name": "shapeColor", "$ref": "RGBA", "optional": true, "h idden": true, "description": "The shape outside fill color (default: transparent )." },
2368 { "name": "shapeMarginColor", "$ref": "RGBA", "optional": tr ue, "hidden": true, "description": "The shape margin fill color (default: transp arent)." } 2368 { "name": "shapeMarginColor", "$ref": "RGBA", "optional": tr ue, "hidden": true, "description": "The shape margin fill color (default: transp arent)." }
2369 ], 2369 ],
2370 "description": "Configuration data for the highlighting of page elements." 2370 "description": "Configuration data for the highlighting of page elements."
2371 },
2372 {
2373 "id": "InspectMode",
2374 "type": "string",
2375 "hidden": true,
2376 "enum": [
2377 "searchForNode",
2378 "searchForUAShadowDOM",
2379 "none"
2380 ]
2371 } 2381 }
2372 ], 2382 ],
2373 "commands": [ 2383 "commands": [
2374 { 2384 {
2375 "name": "enable", 2385 "name": "enable",
2376 "description": "Enables DOM agent for the given page." 2386 "description": "Enables DOM agent for the given page."
2377 }, 2387 },
2378 { 2388 {
2379 "name": "disable", 2389 "name": "disable",
2380 "description": "Disables DOM agent for the given page." 2390 "description": "Disables DOM agent for the given page."
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
2524 "name": "requestNode", 2534 "name": "requestNode",
2525 "parameters": [ 2535 "parameters": [
2526 { "name": "objectId", "$ref": "Runtime.RemoteObjectId", "des cription": "JavaScript object id to convert into node." } 2536 { "name": "objectId", "$ref": "Runtime.RemoteObjectId", "des cription": "JavaScript object id to convert into node." }
2527 ], 2537 ],
2528 "returns": [ 2538 "returns": [
2529 { "name": "nodeId", "$ref": "NodeId", "description": "Node i d for given object." } 2539 { "name": "nodeId", "$ref": "NodeId", "description": "Node i d for given object." }
2530 ], 2540 ],
2531 "description": "Requests that the node is sent to the caller giv en the JavaScript node object reference. All nodes that form the path from the n ode to the root are also sent to the client as a series of <code>setChildNodes</ code> notifications." 2541 "description": "Requests that the node is sent to the caller giv en the JavaScript node object reference. All nodes that form the path from the n ode to the root are also sent to the client as a series of <code>setChildNodes</ code> notifications."
2532 }, 2542 },
2533 { 2543 {
2534 "name": "setInspectModeEnabled", 2544 "name": "setInspectMode",
2535 "hidden": true, 2545 "hidden": true,
2536 "parameters": [ 2546 "parameters": [
2537 { "name": "enabled", "type": "boolean", "description": "True to enable inspection mode, false to disable it." }, 2547 { "name": "mode", "$ref": "InspectMode", "description": "Set an inspection mode." },
2538 { "name": "inspectUAShadowDOM", "type": "boolean", "optional ": true, "description": "True to enable inspection mode for user agent shadow DO M." },
2539 { "name": "highlightConfig", "$ref": "HighlightConfig", "opt ional": true, "description": "A descriptor for the highlight appearance of hover ed-over nodes. May be omitted if <code>enabled == false</code>." } 2548 { "name": "highlightConfig", "$ref": "HighlightConfig", "opt ional": true, "description": "A descriptor for the highlight appearance of hover ed-over nodes. May be omitted if <code>enabled == false</code>." }
2540 ], 2549 ],
2541 "description": "Enters the 'inspect' mode. In this mode, element s that user is hovering over are highlighted. Backend then generates 'inspectNod eRequested' event upon element selection." 2550 "description": "Enters the 'inspect' mode. In this mode, element s that user is hovering over are highlighted. Backend then generates 'inspectNod eRequested' event upon element selection."
2542 }, 2551 },
2543 { 2552 {
2544 "name": "highlightRect", 2553 "name": "highlightRect",
2545 "parameters": [ 2554 "parameters": [
2546 { "name": "x", "type": "integer", "description": "X coordina te" }, 2555 { "name": "x", "type": "integer", "description": "X coordina te" },
2547 { "name": "y", "type": "integer", "description": "Y coordina te" }, 2556 { "name": "y", "type": "integer", "description": "Y coordina te" },
2548 { "name": "width", "type": "integer", "description": "Rectan gle width" }, 2557 { "name": "width", "type": "integer", "description": "Rectan gle width" },
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
2744 "events": [ 2753 "events": [
2745 { 2754 {
2746 "name": "documentUpdated", 2755 "name": "documentUpdated",
2747 "description": "Fired when <code>Document</code> has been totall y updated. Node ids are no longer valid." 2756 "description": "Fired when <code>Document</code> has been totall y updated. Node ids are no longer valid."
2748 }, 2757 },
2749 { 2758 {
2750 "name": "inspectNodeRequested", 2759 "name": "inspectNodeRequested",
2751 "parameters": [ 2760 "parameters": [
2752 { "name": "backendNodeId", "$ref": "BackendNodeId", "descrip tion": "Id of the node to inspect." } 2761 { "name": "backendNodeId", "$ref": "BackendNodeId", "descrip tion": "Id of the node to inspect." }
2753 ], 2762 ],
2754 "description": "Fired when the node should be inspected. This ha ppens after call to <code>setInspectModeEnabled</code>.", 2763 "description": "Fired when the node should be inspected. This ha ppens after call to <code>setInspectMode</code>.",
2755 "hidden" : true 2764 "hidden" : true
2756 }, 2765 },
2757 { 2766 {
2758 "name": "setChildNodes", 2767 "name": "setChildNodes",
2759 "parameters": [ 2768 "parameters": [
2760 { "name": "parentId", "$ref": "NodeId", "description": "Pare nt node id to populate with children." }, 2769 { "name": "parentId", "$ref": "NodeId", "description": "Pare nt node id to populate with children." },
2761 { "name": "nodes", "type": "array", "items": { "$ref": "Node " }, "description": "Child nodes array." } 2770 { "name": "nodes", "type": "array", "items": { "$ref": "Node " }, "description": "Child nodes array." }
2762 ], 2771 ],
2763 "description": "Fired when backend wants to provide client with the missing DOM structure. This happens upon most of the calls requesting node i ds." 2772 "description": "Fired when backend wants to provide client with the missing DOM structure. This happens upon most of the calls requesting node i ds."
2764 }, 2773 },
(...skipping 2447 matching lines...) Expand 10 before | Expand all | Expand 10 after
5212 ], 5221 ],
5213 "returns": [ 5222 "returns": [
5214 { "name": "accessibilityNode", "$ref": "AXNode", "descriptio n": "The <code>Accessibility.AXNode</code> for this DOM node, if it exists.", "o ptional": true } 5223 { "name": "accessibilityNode", "$ref": "AXNode", "descriptio n": "The <code>Accessibility.AXNode</code> for this DOM node, if it exists.", "o ptional": true }
5215 ], 5224 ],
5216 "description": "Fetches the accessibility node for this DOM node , if it exists.", 5225 "description": "Fetches the accessibility node for this DOM node , if it exists.",
5217 "hidden": true 5226 "hidden": true
5218 } 5227 }
5219 ] 5228 ]
5220 }] 5229 }]
5221 } 5230 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/sdk/DOMModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698