LayoutTests/inspector-protocol/dom/dom-setInspectModeEnabled.html - Issue 1310273006: Devtools: convert pair of booleans in setInspectModeEnabled into enum parameter

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/inspector-protocol/dom/dom-setInspectModeEnabled.html

Issue 1310273006: Devtools: convert pair of booleans in setInspectModeEnabled into enum parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script type="text/javascript" src="../../http/tests/inspector-protocol/inspecto r-protocol-test.js"></script>	3 <script type="text/javascript" src="../../http/tests/inspector-protocol/inspecto r-protocol-test.js"></script>

4 <script>	4 <script>

5	5

6 function test()	6 function test()

7 {	7 {

8 var nodeInfo = {};	8 var nodeInfo = {};

9 InspectorTest.eventHandler["DOM.setChildNodes"] = setChildNodes;	9 InspectorTest.eventHandler["DOM.setChildNodes"] = setChildNodes;

10 InspectorTest.eventHandler["DOM.inspectNodeRequested"] = inspectNodeRequeste d;	10 InspectorTest.eventHandler["DOM.inspectNodeRequested"] = inspectNodeRequeste d;

11 InspectorTest.sendCommand("DOM.enable", {});	11 InspectorTest.sendCommand("DOM.enable", {});

12 InspectorTest.sendCommand("DOM.setInspectModeEnabled", { "enabled": true, hi ghlightConfig: {} }, onSetModeEnabled);	12 InspectorTest.sendCommand("DOM.setInspectMode", { "mode": "searchForNode", h ighlightConfig: {} }, onSetModeEnabled);

13	13

14 function onSetModeEnabled(message)	14 function onSetModeEnabled(message)

15 {	15 {

16 if (message.error) {	16 if (message.error) {

17 InspectorTest.log(message.error.message);	17 InspectorTest.log(message.error.message);

18 InspectorTest.completeTest();	18 InspectorTest.completeTest();

19 return;	19 return;

20 }	20 }

21	21

22 InspectorTest.sendCommand("Input.dispatchMouseEvent", { "type": "mouseMo ved", "button": "left", "clickCount": 1, "x": 150, "y": 150 });	22 InspectorTest.sendCommand("Input.dispatchMouseEvent", { "type": "mouseMo ved", "button": "left", "clickCount": 1, "x": 150, "y": 150 });

(...skipping 21 matching lines...) Expand all Loading...
44 InspectorTest.completeTest();	44 InspectorTest.completeTest();

45 }	45 }

46 }	46 }

47	47

48 </script>	48 </script>

49 </head>	49 </head>

50 <body onload="runTest()">	50 <body onload="runTest()">

51 <div style="position:absolute;top:100;left:100;width:100;height:100;background:b lack"></div>	51 <div style="position:absolute;top:100;left:100;width:100;height:100;background:b lack"></div>

52 </body>	52 </body>

53 </html>	53 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/inspector/elements/inspect-mode-shadow-text.html » ('j') | no next file with comments »