Make pub lish validation gitignore-aware.

lib/src/package.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library pub.package;
 
 import 'dart:io';
 
 import 'package:barback/barback.dart';
 import 'package:path/path.dart' as p;
@@ skipping 77 matching lines @@
     }).toList();
   }
 
   /// Returns the path to the README file at the root of the entrypoint, or null
   /// if no README file is found.
   ///
   /// If multiple READMEs are found, this uses the same conventions as
   /// pub.dartlang.org for choosing the primary one: the README with the fewest
   /// extensions that is lexically ordered first is chosen.
   String get readmePath {
-    var readmes = listFiles(recursive: false).map(p.basename).
-        where((entry) => entry.contains(_README_REGEXP));
+    var readmes = listFiles(recursive: false, useGitIgnore: true)
+        .map(p.basename)
+        .where((entry) => entry.contains(_README_REGEXP));
     if (readmes.isEmpty) return null;
 
     return p.join(dir, readmes.reduce((readme1, readme2) {
       var extensions1 = ".".allMatches(readme1).length;
       var extensions2 = ".".allMatches(readme2).length;
       var comparison = extensions1.compareTo(extensions2);
       if (comparison == 0) comparison = readme1.compareTo(readme2);
       return (comparison <= 0) ? readme1 : readme2;
     }));
   }
@@ skipping 77 matching lines @@
   static final _WHITELISTED_FILES = const ['.htaccess'];
 
   /// A set of patterns that match paths to blacklisted files.
   static final _blacklistedFiles = createFileFilter(['pubspec.lock']);
 
   /// A set of patterns that match paths to blacklisted directories.
   static final _blacklistedDirs = createDirectoryFilter(['packages']);
 
   /// Returns a list of files that are considered to be part of this package.
   ///
-  /// If this is a Git repository, this will respect .gitignore; otherwise, it
-  /// will return all non-hidden, non-blacklisted files.
-  ///
   /// If [beneath] is passed, this will only return files beneath that path,
   /// which is expected to be relative to the package's root directory. If
   /// [recursive] is true, this will return all files beneath that path;
   /// otherwise, it will only return files one level beneath it.
   ///
   /// If [useGitIgnore] is passed, this will take the .gitignore rules into
-  /// account if the package's root directory is a Git repository.
+  /// account if the root directory of the package is (or is contained within) a
+  /// Git repository.
   ///
   /// Note that the returned paths won't always be beneath [dir]. To safely
   /// convert them to paths relative to the package root, use [relative].
   List<String> listFiles({String beneath, bool recursive: true,
       bool useGitIgnore: false}) {
     // An in-memory package has no files.
     if (dir == null) return [];
 
     if (beneath == null) {
       beneath = dir;
@@ skipping 218 matching lines @@
 
   bool operator ==(other) {
     // TODO(rnystrom): We're assuming here that we don't need to delve into the
     // description.
     return other is PackageDep &&
            other.name == name &&
            other.source == source &&
            other.constraint == constraint;
   }
 }