MIPS: [es6] Initial steps towards a correct implementation of IsCallable.

MIPS: [es6] Initial steps towards a correct implementation of IsCallable.

Port of https://codereview.chromium.org/1316933002/

BUG=

[paul.l..., 2015-08-27 17:59:32]

paul.lind@imgtec.com changed reviewers:
+ paul.lind@imgtec.com

[paul.l..., 2015-08-27 17:59:32]

https://codereview.chromium.org/1310233004/diff/1/src/mips/lithium-codegen-mi...
File src/mips/lithium-codegen-mips.cc (right):

https://codereview.chromium.org/1310233004/diff/1/src/mips/lithium-codegen-mi...
src/mips/lithium-codegen-mips.cc:5595: __ Branch(false_label, lt, at,
Operand(FIRST_SPEC_OBJECT_TYPE));
It's a bit dodgy to use 'at' here. It happens to work when the value is int16_t,
and the  condition is not eq/ne. This seems fragile. It looks like you can
safely use 'scratch'. Please change to that if you agree.

https://codereview.chromium.org/1310233004/diff/1/src/mips64/lithium-codegen-...
File src/mips64/lithium-codegen-mips64.cc (right):

https://codereview.chromium.org/1310233004/diff/1/src/mips64/lithium-codegen-...
src/mips64/lithium-codegen-mips64.cc:5782: __ Branch(false_label, lt, at,
Operand(FIRST_SPEC_OBJECT_TYPE));
Also change at to scratch here (as in mips32 port)

[akos.palfi.imgtec, 2015-08-27 18:51:17]

Thanks, I've addressed the comments, PTAL.

https://codereview.chromium.org/1310233004/diff/1/src/mips/lithium-codegen-mi...
File src/mips/lithium-codegen-mips.cc (right):

https://codereview.chromium.org/1310233004/diff/1/src/mips/lithium-codegen-mi...
src/mips/lithium-codegen-mips.cc:5595: __ Branch(false_label, lt, at,
Operand(FIRST_SPEC_OBJECT_TYPE));
On 2015/08/27 17:59:32, paul.l... wrote:
> It's a bit dodgy to use 'at' here. It happens to work when the value is
int16_t,
> and the  condition is not eq/ne. This seems fragile. It looks like you can
> safely use 'scratch'. Please change to that if you agree.

Done.

https://codereview.chromium.org/1310233004/diff/1/src/mips64/lithium-codegen-...
File src/mips64/lithium-codegen-mips64.cc (right):

https://codereview.chromium.org/1310233004/diff/1/src/mips64/lithium-codegen-...
src/mips64/lithium-codegen-mips64.cc:5782: __ Branch(false_label, lt, at,
Operand(FIRST_SPEC_OBJECT_TYPE));
On 2015/08/27 17:59:32, paul.l... wrote:
> Also change at to scratch here (as in mips32 port)

Done.

[paul.l..., 2015-08-27 18:54:17]

paul.lind@imgtec.com changed reviewers:
+ bmeurer@chromium.org

[paul.l..., 2015-08-27 18:54:17]

l-g-t-m for inclusion in https://codereview.chromium.org/1316933002/

[Benedikt Meurer, 2015-08-28 05:42:29]

On 2015/08/27 18:54:17, paul.l... wrote:
> l-g-t-m for inclusion in https://codereview.chromium.org/1316933002/

Merged. Thanks a lot!