Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 131023004: Moved the --device-management-url switch to the policy component. (Closed)

Created:
6 years, 11 months ago by Joao da Silva
Modified:
6 years, 11 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@BPC-1-split
Visibility:
Public.

Description

Moved the --device-management-url switch to the policy component. BUG=275292 TBR=nkostylev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246115

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/chrome_browser_policy_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/policy/core/common/policy_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/policy/core/common/policy_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Joao da Silva
Here's an easy one.
6 years, 11 months ago (2014-01-21 09:49:34 UTC) #1
dconnelly
On 2014/01/21 09:49:34, Joao da Silva wrote: > Here's an easy one. Failed EVERY BOT.
6 years, 11 months ago (2014-01-21 10:52:32 UTC) #2
Joao da Silva
It'll fail every bot until the other browser_policy_connector patch lands. I can send both to ...
6 years, 11 months ago (2014-01-21 10:54:58 UTC) #3
dconnelly1
I know. I saw the logs. I'm giving you a hard time :) On Tue, ...
6 years, 11 months ago (2014-01-21 10:55:54 UTC) #4
dconnelly
lgtm
6 years, 11 months ago (2014-01-21 10:58:18 UTC) #5
Joao da Silva
Nikita to TBR for chromeos/login changes
6 years, 11 months ago (2014-01-21 19:49:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/131023004/200001
6 years, 11 months ago (2014-01-21 19:50:15 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-21 21:31:15 UTC) #8
Message was sent while issue was closed.
Change committed as 246115

Powered by Google App Engine
This is Rietveld 408576698