Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: chrome/browser/chromeos/first_run/steps/help_step.cc

Issue 131023003: Added UMA metrics for ChromeOS first-run UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/first_run/steps/help_step.cc
diff --git a/chrome/browser/chromeos/first_run/steps/help_step.cc b/chrome/browser/chromeos/first_run/steps/help_step.cc
index b65d4934aedc7a54859664f3bcb9f36edf99d8df..8c6d080bbc88374f717ae87ba19f71d23b29c3ac 100644
--- a/chrome/browser/chromeos/first_run/steps/help_step.cc
+++ b/chrome/browser/chromeos/first_run/steps/help_step.cc
@@ -22,7 +22,7 @@ HelpStep::HelpStep(ash::FirstRunHelper* shell_helper, FirstRunActor* actor)
: Step(kHelpStep, shell_helper, actor) {
}
-void HelpStep::Show() {
+void HelpStep::DoShow() {
if (!shell_helper()->IsTrayBubbleOpened())
shell_helper()->OpenTrayBubble();
gfx::Rect button_bounds = shell_helper()->GetHelpButtonBounds();
@@ -31,9 +31,7 @@ void HelpStep::Show() {
actor()->ShowStepPointingTo(name(), center.x(), center.y(), kCircleRadius);
}
-void HelpStep::OnAfterHide() {
- shell_helper()->CloseTrayBubble();
-}
+void HelpStep::DoOnAfterHide() { shell_helper()->CloseTrayBubble(); }
Alexei Svitkine (slow) 2014/01/15 16:02:38 Nit: I think putting method on the same line is do
dzhioev (left Google) 2014/01/15 22:12:54 That's what 'git cl format' did and I missed it. R
} // namespace first_run
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698