Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.h

Issue 1310223002: webapps: initial addition of splash screen icon downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-database-exp
Patch Set: Fix review comments and update code as discussed Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.h
diff --git a/chrome/browser/android/banners/app_banner_manager_android.h b/chrome/browser/android/banners/app_banner_manager_android.h
index 0beea17a63aea754bd0ce90af47dab87dde27e87..1e9c7924c284539cadc091d482453274c64c8684 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.h
+++ b/chrome/browser/android/banners/app_banner_manager_android.h
@@ -25,7 +25,10 @@ class AppBannerManagerAndroid : public AppBannerManager {
// Registers native methods.
static bool Register(JNIEnv* env);
- AppBannerManagerAndroid(JNIEnv* env, jobject obj, int icon_size);
+ AppBannerManagerAndroid(JNIEnv* env,
+ jobject obj,
+ int splash_icon_size,
Lalit Maganti 2015/08/26 13:11:56 Changed to have "ideal" and "in dp"
+ int icon_size);
Lalit Maganti 2015/08/26 13:11:56 Changed to have "ideal" and "in dp"
~AppBannerManagerAndroid() override;
// Destroys the AppBannerManagerAndroid.
@@ -66,6 +69,9 @@ class AppBannerManagerAndroid : public AppBannerManager {
std::string ExtractQueryValueForName(const GURL& url,
const std::string& name);
+ // Ideal splashscreen icon size to use.
+ const int ideal_splash_icon_size_;
Lalit Maganti 2015/08/26 13:11:56 Changed to have "ideal" and "in dp"
+
// AppBannerManager on the Java side.
JavaObjectWeakGlobalRef weak_java_banner_view_manager_;

Powered by Google App Engine
This is Rietveld 408576698