Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3769)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.h

Issue 1310223002: webapps: initial addition of splash screen icon downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-database-exp
Patch Set: Fix compile Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.h
diff --git a/chrome/browser/android/banners/app_banner_manager_android.h b/chrome/browser/android/banners/app_banner_manager_android.h
index 0beea17a63aea754bd0ce90af47dab87dde27e87..4fd358b9a42891e9cc15bf184e8b745c13772bbb 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.h
+++ b/chrome/browser/android/banners/app_banner_manager_android.h
@@ -25,7 +25,10 @@ class AppBannerManagerAndroid : public AppBannerManager {
// Registers native methods.
static bool Register(JNIEnv* env);
- AppBannerManagerAndroid(JNIEnv* env, jobject obj, int icon_size);
+ AppBannerManagerAndroid(JNIEnv* env,
+ jobject obj,
+ int ideal_splash_image_size_in_dp,
+ int ideal_icon_size_in_dp);
~AppBannerManagerAndroid() override;
// Destroys the AppBannerManagerAndroid.
@@ -51,7 +54,7 @@ class AppBannerManagerAndroid : public AppBannerManager {
protected:
AppBannerDataFetcher* CreateAppBannerDataFetcher(
base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate,
- const int ideal_icon_size) override;
+ const int ideal_icon_size_in_dp) override;
private:
// AppBannerDataFetcher::Delegate overrides.
@@ -66,6 +69,9 @@ class AppBannerManagerAndroid : public AppBannerManager {
std::string ExtractQueryValueForName(const GURL& url,
const std::string& name);
+ // Ideal splash screen image size to use.
+ const int ideal_splash_image_size_in_dp_;
+
// AppBannerManager on the Java side.
JavaObjectWeakGlobalRef weak_java_banner_view_manager_;

Powered by Google App Engine
This is Rietveld 408576698