chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java - Issue 1310223002: webapps: initial addition of splash screen icon downloading

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java

Issue 1310223002: webapps: initial addition of splash screen icon downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-database-exp

Patch Set: Fix compile Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java ('k') | chrome/browser/android/banners/app_banner_data_fetcher_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java

index 410e1235bd07bfe775c6cf9e6881490d39cb3b5a..00981d0be364d23915de0ffc1d4662e6317b5565 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java

@@ -13,10 +13,12 @@ import android.text.TextUtils;

import org.chromium.base.ThreadUtils;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.UrlUtils;

+import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.test.ChromeActivityTestCaseBase;

+import org.chromium.chrome.test.util.TestHttpServerClient;

import org.chromium.chrome.test.util.browser.TabLoadObserver;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

@@ -59,6 +61,10 @@ public class AddToHomescreenDialogHelperTest extends ChromeActivityTestCaseBase<

+ "<title>" + META_APP_NAME_PAGE_TITLE + "</title>"

+ "</head><body>Webapp capable</body></html>");

+ private static final String MANIFEST_URL =

+ TestHttpServerClient.getUrl("chrome/test/data/webapps/manifest_test_page.html");

+ private static final String MANIFEST_TITLE = "Web app banner test page";

private static class TestShortcutHelperDelegate extends ShortcutHelper.Delegate {

public Intent mBroadcastedIntent;

@@ -77,6 +83,28 @@ public class AddToHomescreenDialogHelperTest extends ChromeActivityTestCaseBase<

}

+ private static class TestDataStorageFactory extends WebappDataStorage.Factory {

+ public Bitmap mSplashImage;

+ @Override

+ public WebappDataStorage create(final Context context, final String webappId) {

+ return new WebappDataStorageWrapper(context, webappId);

+ }

+ private class WebappDataStorageWrapper extends WebappDataStorage {

+ public WebappDataStorageWrapper(Context context, String webappId) {

+ super(context, webappId);

+ }

+ @Override

+ public void updateSplashScreenImage(Bitmap splashScreenImage) {

+ assertNull(mSplashImage);

+ mSplashImage = splashScreenImage;

+ }

private ChromeActivity mActivity;

private TestShortcutHelperDelegate mShortcutHelperDelegate;

@@ -164,6 +192,30 @@ public class AddToHomescreenDialogHelperTest extends ChromeActivityTestCaseBase<

assertEquals(META_APP_NAME_TITLE, firedIntent.getStringExtra(Intent.EXTRA_SHORTCUT_NAME));

}

+ @SmallTest

+ @Feature("{Webapp}")

+ public void testAddWebappShortcutSplashScreenIcon() throws InterruptedException {

+ // Sets the overriden factory to observer splash screen update.

+ final TestDataStorageFactory dataStorageFactory = new TestDataStorageFactory();

+ WebappDataStorage.setFactoryForTests(dataStorageFactory);

+ addShortcutToURL(MANIFEST_URL, MANIFEST_TITLE, "");

+ // Make sure that the splash screen image was downloaded.

+ assertTrue(CriteriaHelper.pollForUIThreadCriteria(new Criteria() {

+ @Override

+ public boolean isSatisfied() {

+ return dataStorageFactory.mSplashImage != null;

+ }

+ }));

+ // Test that bitmap sizes match expectations.

+ int idealSize = mActivity.getResources().getDimensionPixelSize(

+ R.dimen.webapp_splash_image_size);

+ assertEquals(idealSize, dataStorageFactory.mSplashImage.getWidth());

+ assertEquals(idealSize, dataStorageFactory.mSplashImage.getHeight());

+ }

private void addShortcutToURL(String url, final String expectedPageTitle, final String title)

throws InterruptedException {

final Tab activeTab = mActivity.getActivityTab();