Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.h

Issue 1310223002: webapps: initial addition of splash screen icon downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-database-exp
Patch Set: Add call to webapp storage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher.h
diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h
index 69d647e801219a4ca5e2d304d6819025094c777a..31206c12cd4ee2c0b8dee4b26e1c8254a61ff120 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.h
+++ b/chrome/browser/banners/app_banner_data_fetcher.h
@@ -121,7 +121,7 @@ class AppBannerDataFetcher
// Called when it is determined that the webapp has fulfilled the initial
// criteria of having a manifest and a service worker.
- void OnHasServiceWorker(content::WebContents* web_contents);
+ virtual void OnHasServiceWorker(content::WebContents* web_contents);
content::WebContents* GetWebContents();
virtual std::string GetAppIdentifier();
@@ -137,6 +137,10 @@ class AppBannerDataFetcher
// metric being recorded.
void RecordDidShowBanner(const std::string& event_name);
+ // Returns whether the fetcher is active and web contents have not been
+ // closed.
+ bool CheckFetcherIsStillAlive(content::WebContents* web_contents);
+
private:
// Callbacks for data retrieval.
void OnDidGetManifest(const content::Manifest& manifest);
@@ -160,10 +164,6 @@ class AppBannerDataFetcher
// Returns whether the banner should be shown.
bool CheckIfShouldShowBanner();
- // Returns whether the fetcher is active and web contents have not been
- // closed.
- bool CheckFetcherIsStillAlive(content::WebContents* web_contents);
-
// Returns whether the given Manifest is following the requirements to show
// a web app banner.
static bool IsManifestValidForWebApp(const content::Manifest& manifest,

Powered by Google App Engine
This is Rietveld 408576698