webapps: initial addition of splash screen icon downloading

chrome/browser/android/banners/app_banner_data_fetcher_android.cc

Index: chrome/browser/android/banners/app_banner_data_fetcher_android.cc
diff --git a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
index 024b456678bcbab1d3a3bd7c6a0208a5491127b1..608fc8e885f3e9b536a559503eab6be0c6545630 100644
--- a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
+++ b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
@@ -4,19 +4,26 @@
 
 #include "chrome/browser/android/banners/app_banner_data_fetcher_android.h"
 
+#include "base/bind.h"
 #include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h"
+#include "chrome/browser/banners/app_banner_debug_log.h"
 #include "chrome/browser/banners/app_banner_metrics.h"
 #include "chrome/browser/infobars/infobar_service.h"
+#include "chrome/browser/manifest/manifest_icon_downloader.h"
+#include "chrome/browser/manifest/manifest_icon_selector.h"
 #include "chrome/browser/ui/android/infobars/app_banner_infobar_android.h"
 #include "third_party/skia/include/core/SkBitmap.h"
+#include "ui/gfx/screen.h"
 
 namespace banners {
 
 AppBannerDataFetcherAndroid::AppBannerDataFetcherAndroid(
     content::WebContents* web_contents,
     base::WeakPtr<Delegate> weak_delegate,
+    int ideal_splash_icon_size,
     int ideal_icon_size)
-    : AppBannerDataFetcher(web_contents, weak_delegate, ideal_icon_size) {
+    : AppBannerDataFetcher(web_contents, weak_delegate, ideal_icon_size),
+      ideal_splash_icon_size_(ideal_splash_icon_size) {
 }
 
 AppBannerDataFetcherAndroid::~AppBannerDataFetcherAndroid() {
@@ -43,6 +50,48 @@ std::string AppBannerDataFetcherAndroid::GetAppIdentifier() {
       ? AppBannerDataFetcher::GetAppIdentifier() : native_app_package_;
 }
 
+void AppBannerDataFetcherAndroid::OnHasServiceWorker(
+    content::WebContents* web_contents) {
+  // We intercept the data fetch flow and inject downloading of the splash
+  // screen icon at the point just before the app icon is downloaded.
+  GURL icon_url =
+    ManifestIconSelector::FindBestMatchingIcon(
+        web_app_data().icons,
+        ideal_splash_icon_size_,
+        gfx::Screen::GetScreenFor(web_contents->GetNativeView()));
+
+  if (!ManifestIconDownloader::Download(
+          web_contents,
+          icon_url,
+          ideal_splash_icon_size_,
+          base::Bind(&AppBannerDataFetcherAndroid::OnSplashIconFetched,
+                     this))) {
+    OutputDeveloperNotShownMessage(web_contents,
+        kCannotDetermineBestSplashIcon);
+    Cancel();

[mlamouri (slow - plz ping), 2015/08/24 16:43:54]

see below.

[Lalit Maganti, 2015/08/25 11:38:44]

Acknowledged.

+  }
+}
+
+void AppBannerDataFetcherAndroid::OnSplashIconFetched(const SkBitmap& bitmap) {
+  if (!is_active()) return;
+
+  content::WebContents* web_contents = GetWebContents();
+  if (!CheckFetcherIsStillAlive(web_contents)) {
+    Cancel();
+    return;
+  }
+  if (bitmap.drawsNothing()) {
+    OutputDeveloperNotShownMessage(web_contents, kNoSplashIconAvailable);
+    Cancel();

[mlamouri (slow - plz ping), 2015/08/24 16:43:54]

You are making the splashscreen icon a requirement in order to show the app
banner. Is that on purpose? I don't think we should do that for now. We can
check with app banners stackholders whether they are fine with that. At least,
we should require background_color if we require a splashscreen icon.

[Lalit Maganti, 2015/08/25 11:38:44]

Changed according to our discussions.

+    return;
+  }
+
+  splash_icon_.reset(new SkBitmap(bitmap));
+
+  // Continue the fetch cycle as normal.
+  AppBannerDataFetcher::OnHasServiceWorker(web_contents);

[mlamouri (slow - plz ping), 2015/08/24 16:43:54]

Maybe you could do something like:

void AppBannerDataFetcherAndroid::OnHasServiceWorker(WebContents* web_contents)
{
  AppBannerDataFetcher::OnHasServiceWorker(web_contents);

  // The base class already cancelled the process.
  if (!is_active)
    return;

  // Find the splashscreen if any the download it and set it.
}

[Lalit Maganti, 2015/08/25 11:38:44]

This code has been redone completely.

+}
+
 void AppBannerDataFetcherAndroid::ShowBanner(const SkBitmap* icon,
                                              const base::string16& title,
                                              const std::string& referrer) {
@@ -53,7 +102,8 @@ void AppBannerDataFetcherAndroid::ShowBanner(const SkBitmap* icon,
   if (native_app_data_.is_null()) {
     scoped_ptr<AppBannerInfoBarDelegateAndroid> delegate(
         new AppBannerInfoBarDelegateAndroid(
-            event_request_id(), title, new SkBitmap(*icon), web_app_data()));
+            event_request_id(), title, splash_icon_.release(),
+            new SkBitmap(*icon), web_app_data()));
 
     infobar =
         new AppBannerInfoBarAndroid(delegate.Pass(), web_app_data().start_url);